SameSite parsing should be stricter: https://httpwg.org/http-extensions/rfc6265bis.html#the-samesite-attribute-1 SameSite=lax => Lax SameSite=strict => Strict SameSite => Ignore SameSite=unknown => Ignore
<rdar://problem/42291601>
Created attachment 367445 [details] [PATCH] Proposed Fix
Comment on attachment 367445 [details] [PATCH] Proposed Fix r=me, please update the expected result for `inspector/unit-tests/cookie.html` :)
Created attachment 367449 [details] [PATCH] For Landing
Created attachment 367452 [details] [PATCH] For Landing
Comment on attachment 367445 [details] [PATCH] Proposed Fix Attachment 367445 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11874748 New failing tests: inspector/unit-tests/cookie.html
Created attachment 367454 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 367445 [details] [PATCH] Proposed Fix Attachment 367445 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11875103 New failing tests: inspector/unit-tests/cookie.html
Created attachment 367463 [details] Archive of layout-test-results from ews116 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 367452 [details] [PATCH] For Landing Clearing flags on attachment: 367452 Committed r244294: <https://trac.webkit.org/changeset/244294>
After changes in https://trac.webkit.org/changeset/244294 http/tests/inspector/network/har/har-page.html is failing on WK2 Release and Debug builds. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html Was a flaky timeout/failure in previous revisions. Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt @@ -588,8 +588,7 @@ "path": "/", "expires": "", "httpOnly": false, - "secure": false, - "sameSite": "Strict" + "secure": false } ], "headers": "<filtered>", @@ -661,8 +660,7 @@ "path": "/", "expires": "", "httpOnly": false, - "secure": false, - "sameSite": "Strict" + "secure": false } ], "headers": "<filtered>",
(In reply to Shawn Roberts from comment #11) > After changes in https://trac.webkit.org/changeset/244294 > > http/tests/inspector/network/har/har-page.html is failing on WK2 Release and > Debug builds. > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar- > page.html > > Was a flaky timeout/failure in previous revisions. > > Diff: > > --- > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/ > tests/inspector/network/har/har-page-expected.txt > +++ > /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/ > tests/inspector/network/har/har-page-actual.txt > @@ -588,8 +588,7 @@ > "path": "/", > "expires": "", > "httpOnly": false, > - "secure": false, > - "sameSite": "Strict" > + "secure": false > } > ], > "headers": "<filtered>", > @@ -661,8 +660,7 @@ > "path": "/", > "expires": "", > "httpOnly": false, > - "secure": false, > - "sameSite": "Strict" > + "secure": false > } > ], > "headers": "<filtered>", Oops, yes updating now.
> Oops, yes updating now. Test + Expectations updated in: https://trac.webkit.org/r244345