Bug 196923 - Several structures and enums in the Yarr interpreter can be shrunk
Summary: Several structures and enums in the Yarr interpreter can be shrunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-15 11:46 PDT by Robin Morisset
Modified: 2019-04-15 13:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.42 KB, patch)
2019-04-15 11:51 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-04-15 11:46:59 PDT
YarrOp: 88 -> 80
RegularExpression: 40 -> 32
ByteTerm: 56 -> 48
PatternTerm: 56 -> 48
Comment 1 Robin Morisset 2019-04-15 11:51:17 PDT
Created attachment 367436 [details]
Patch

trivial shrinking of enums and reordering of the fields of structs.
Comment 2 Build Bot 2019-04-15 11:53:57 PDT
Attachment 367436 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/yarr/YarrInterpreter.h:380:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2019-04-15 13:39:17 PDT
Comment on attachment 367436 [details]
Patch

Clearing flags on attachment: 367436

Committed r244286: <https://trac.webkit.org/changeset/244286>
Comment 4 WebKit Commit Bot 2019-04-15 13:39:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-15 13:40:19 PDT
<rdar://problem/49915584>