Bug 196904 - [CMake] WebCore derived sources should only be referenced inside WebCore
Summary: [CMake] WebCore derived sources should only be referenced inside WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 196704
  Show dependency tree / graph
 
Reported: 2019-04-14 07:15 PDT by Don Olmstead
Modified: 2019-04-15 14:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (44.78 KB, patch)
2019-04-15 09:43 PDT, Don Olmstead 		annulen: review+
Details | Formatted Diff | Diff
Patch (44.33 KB, patch)
2019-04-15 14:02 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-04-14 07:15:07 PDT 
Anything outside of Source/JavaScriptCore should NOT be touching JavaScriptCore's derived sources.
Comment 1 Don Olmstead 2019-04-15 09:43:30 PDT 
Created attachment 367419 [details]
Patch
Comment 2 Konstantin Tokarev 2019-04-15 09:55:36 PDT 
Comment on attachment 367419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367419&action=review

> Source/cmake/WebKitMacros.cmake:136
> +        if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}")

Here we reference WebCore-specific variable from macro which is used in other targets. Looks suspicious.

> Source/cmake/WebKitMacros.cmake:142
> +    source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}")

Ditto.
Comment 3 Don Olmstead 2019-04-15 10:44:15 PDT 
(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 367419 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367419&action=review
> 
> > Source/cmake/WebKitMacros.cmake:136
> > +        if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}")
> 
> Here we reference WebCore-specific variable from macro which is used in
> other targets. Looks suspicious.
> 
> > Source/cmake/WebKitMacros.cmake:142
> > +    source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}")
> 
> Ditto.

Removing in https://bugs.webkit.org/show_bug.cgi?id=196916
Comment 4 Don Olmstead 2019-04-15 14:02:24 PDT 
Created attachment 367456 [details]
Patch

Remove changes to WebKitMacros.
Comment 5 WebKit Commit Bot 2019-04-15 14:46:42 PDT 
Comment on attachment 367456 [details]
Patch

Clearing flags on attachment: 367456

Committed r244292: <https://trac.webkit.org/changeset/244292>
Comment 6 WebKit Commit Bot 2019-04-15 14:46:43 PDT 
All reviewed patches have been landed.  Closing bug.