Bug 196904 – [CMake] WebCore derived sources should only be referenced inside WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Don Olmstead]

Anything outside of Source/JavaScriptCore should NOT be touching JavaScriptCore's derived sources.

[Don Olmstead]

Created attachment 367419 [details]
Patch

[Konstantin Tokarev]

Comment on attachment 367419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367419&action=review

> Source/cmake/WebKitMacros.cmake:136
> +        if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}")

Here we reference WebCore-specific variable from macro which is used in other targets. Looks suspicious.

> Source/cmake/WebKitMacros.cmake:142
> +    source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}")

Ditto.

[Don Olmstead]

(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 367419 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367419&action=review
> 
> > Source/cmake/WebKitMacros.cmake:136
> > +        if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}")
> 
> Here we reference WebCore-specific variable from macro which is used in
> other targets. Looks suspicious.
> 
> > Source/cmake/WebKitMacros.cmake:142
> > +    source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}")
> 
> Ditto.

Removing in https://bugs.webkit.org/show_bug.cgi?id=196916

[Don Olmstead]

Created attachment 367456 [details]
Patch

Remove changes to WebKitMacros.

[WebKit Commit Bot]

Comment on attachment 367456 [details]
Patch

Clearing flags on attachment: 367456

Committed r244292: <https://trac.webkit.org/changeset/244292>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.