Bug 196889 - Web Inspector: Heap: logging an object from a snapshot shouldn't use the "special" style if the object is reachable
Summary: Web Inspector: Heap: logging an object from a snapshot shouldn't use the "spe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-12 18:23 PDT by Devin Rousso
Modified: 2019-04-15 11:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2019-04-12 18:28 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-12 18:23:13 PDT 
`window.foo.bar.baz` vs `Heap Snapshot Object (%s)`
Comment 1 Radar WebKit Bug Importer 2019-04-12 18:24:43 PDT 
<rdar://problem/49870693>
Comment 2 Devin Rousso 2019-04-12 18:28:46 PDT 
Created attachment 367365 [details]
Patch
Comment 3 Joseph Pecoraro 2019-04-15 11:19:14 PDT 
Comment on attachment 367365 [details]
Patch

r=me, Nice!
Comment 4 WebKit Commit Bot 2019-04-15 11:47:43 PDT 
Comment on attachment 367365 [details]
Patch

Clearing flags on attachment: 367365

Committed r244275: <https://trac.webkit.org/changeset/244275>
Comment 5 WebKit Commit Bot 2019-04-15 11:47:45 PDT 
All reviewed patches have been landed.  Closing bug.