Bug 196883 - Enable modern compatibility mode by default in WKWebView on some devices
Summary: Enable modern compatibility mode by default in WKWebView on some devices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-12 16:02 PDT by Wenson Hsieh
Modified: 2019-04-12 20:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (15.13 KB, patch)
2019-04-12 16:23 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix macOS builds (15.11 KB, patch)
2019-04-12 16:42 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-04-12 16:02:57 PDT 
<rdar://problem/49864527>
Comment 1 Wenson Hsieh 2019-04-12 16:23:24 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-04-12 16:42:58 PDT 
Created attachment 367357 [details]
Fix macOS builds
Comment 3 Tim Horton 2019-04-12 17:24:18 PDT 
Comment on attachment 367357 [details]
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=367357&action=review

> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:294
> +    static bool isAppleApplication = applicationBundleStartsWith("com.apple."_s);
> +    return isAppleApplication;

This seems a bit broad as mentioned elsewhere.
Comment 4 Wenson Hsieh 2019-04-12 19:15:03 PDT 
Comment on attachment 367357 [details]
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=367357&action=review

>> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:294
>> +    return isAppleApplication;
> 
> This seems a bit broad as mentioned elsewhere.

Unfortunately, yes 😞. I filed <rdar://problem/49871194> to track this.
Comment 5 WebKit Commit Bot 2019-04-12 20:54:16 PDT 
Comment on attachment 367357 [details]
Fix macOS builds

Clearing flags on attachment: 367357

Committed r244239: <https://trac.webkit.org/changeset/244239>
Comment 6 WebKit Commit Bot 2019-04-12 20:54:17 PDT 
All reviewed patches have been landed.  Closing bug.