Bug 196881 - Run JetStream2 as part of the bytecode cache tests
Summary: Run JetStream2 as part of the bytecode cache tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords:
Depends on: 196865 196878 196880
Blocks:
  Show dependency treegraph
 
Reported: 2019-04-12 15:13 PDT by Tadeu Zagallo
Modified: 2019-04-16 10:13 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.97 KB, patch)
2019-04-12 15:25 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff
patch for landing (4.99 KB, patch)
2019-04-16 04:29 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff
patch for landing (5.08 KB, patch)
2019-04-16 04:51 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-04-12 15:13:06 PDT
...
Comment 1 Tadeu Zagallo 2019-04-12 15:25:52 PDT
Created attachment 367350 [details]
Patch
Comment 2 Saam Barati 2019-04-13 09:14:47 PDT
Comment on attachment 367350 [details]
Patch

r=me
Comment 3 Saam Barati 2019-04-13 09:15:14 PDT
Do we not fail this today?
Comment 4 Saam Barati 2019-04-13 09:16:34 PDT
Also does this work when preparing the tests for iOS devices? Will it package up all of JS2?
Comment 5 Tadeu Zagallo 2019-04-13 10:31:44 PDT
(In reply to Saam Barati from comment #3)
> Do we not fail this today?

Yes, there are a couple other patches that need to land first. I've updated the dependencies to reflect that.

(In reply to Saam Barati from comment #4)
> Also does this work when preparing the tests for iOS devices? Will it
> package up all of JS2?

That's a good question, I will check that.
Comment 6 Tadeu Zagallo 2019-04-16 04:29:06 PDT
Created attachment 367528 [details]
patch for landing
Comment 7 Tadeu Zagallo 2019-04-16 04:46:24 PDT
(In reply to Tadeu Zagallo from comment #5)
> (In reply to Saam Barati from comment #3)
> > Do we not fail this today?
> 
> Yes, there are a couple other patches that need to land first. I've updated
> the dependencies to reflect that.
> 
> (In reply to Saam Barati from comment #4)
> > Also does this work when preparing the tests for iOS devices? Will it
> > package up all of JS2?
> 
> That's a good question, I will check that.

Everything works fine. My only concern is that the test takes nearly 7 minutes on debug builds...
Comment 8 Tadeu Zagallo 2019-04-16 04:51:04 PDT
Created attachment 367530 [details]
patch for landing

Fix missing comma in run-javascriptcore-tests
Comment 9 Saam Barati 2019-04-16 10:13:35 PDT
(In reply to Tadeu Zagallo from comment #7)
> (In reply to Tadeu Zagallo from comment #5)
> > (In reply to Saam Barati from comment #3)
> > > Do we not fail this today?
> > 
> > Yes, there are a couple other patches that need to land first. I've updated
> > the dependencies to reflect that.
> > 
> > (In reply to Saam Barati from comment #4)
> > > Also does this work when preparing the tests for iOS devices? Will it
> > > package up all of JS2?
> > 
> > That's a good question, I will check that.
> 
> Everything works fine. My only concern is that the test takes nearly 7
> minutes on debug builds...

You could edit the benchmark and re-check it in modifying some of the longer running tests to do less inner iterations