...
Created attachment 367350 [details] Patch
Comment on attachment 367350 [details] Patch r=me
Do we not fail this today?
Also does this work when preparing the tests for iOS devices? Will it package up all of JS2?
(In reply to Saam Barati from comment #3) > Do we not fail this today? Yes, there are a couple other patches that need to land first. I've updated the dependencies to reflect that. (In reply to Saam Barati from comment #4) > Also does this work when preparing the tests for iOS devices? Will it > package up all of JS2? That's a good question, I will check that.
Created attachment 367528 [details] patch for landing
(In reply to Tadeu Zagallo from comment #5) > (In reply to Saam Barati from comment #3) > > Do we not fail this today? > > Yes, there are a couple other patches that need to land first. I've updated > the dependencies to reflect that. > > (In reply to Saam Barati from comment #4) > > Also does this work when preparing the tests for iOS devices? Will it > > package up all of JS2? > > That's a good question, I will check that. Everything works fine. My only concern is that the test takes nearly 7 minutes on debug builds...
Created attachment 367530 [details] patch for landing Fix missing comma in run-javascriptcore-tests
(In reply to Tadeu Zagallo from comment #7) > (In reply to Tadeu Zagallo from comment #5) > > (In reply to Saam Barati from comment #3) > > > Do we not fail this today? > > > > Yes, there are a couple other patches that need to land first. I've updated > > the dependencies to reflect that. > > > > (In reply to Saam Barati from comment #4) > > > Also does this work when preparing the tests for iOS devices? Will it > > > package up all of JS2? > > > > That's a good question, I will check that. > > Everything works fine. My only concern is that the test takes nearly 7 > minutes on debug builds... You could edit the benchmark and re-check it in modifying some of the longer running tests to do less inner iterations