Bug 196877 - Provide a quirk to disable Pointer Events
Summary: Provide a quirk to disable Pointer Events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-12 14:14 PDT by Antoine Quint
Modified: 2019-04-13 01:00 PDT (History)
17 users (show)

See Also:


Attachments
Patch (5.00 KB, patch)
2019-04-12 14:16 PDT, Antoine Quint
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-04-12 14:14:31 PDT
We need a quirk to disable Pointer Events wholesale.
Comment 1 Radar WebKit Bug Importer 2019-04-12 14:14:51 PDT
<rdar://problem/49863470>
Comment 2 Antoine Quint 2019-04-12 14:16:20 PDT
Created attachment 367345 [details]
Patch
Comment 3 Dean Jackson 2019-04-12 16:06:24 PDT
Comment on attachment 367345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367345&action=review

> Source/WebCore/ChangeLog:9
> +        Add a quirk to disable Pointer Events and opt a website that has compatibility issues when Pointer Events are enabled into this new quirk.

I think this is correct english, but it was hard to read.

> Source/WebCore/page/Quirks.cpp:239
> +    if (equalLettersIgnoringASCIICase(host, "mailchimp.com") || host.endsWithIgnoringASCIICase(".mailchimp.com"))

Annoying that there might be a site notmailchimp.com, or that we can't say "[\.^]mailchimp\.com$" (not sure that's even a valid regexp)
Comment 4 Antoine Quint 2019-04-13 01:00:56 PDT
Committed r244240: <https://trac.webkit.org/changeset/244240>