Bug 196873 - Web Inspector: drag/drop over the sidebar should load an imported file in Canvas/Audit tab
Summary: Web Inspector: drag/drop over the sidebar should load an imported file in Can...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-12 11:35 PDT by Devin Rousso
Modified: 2019-04-15 11:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.61 KB, patch)
2019-04-12 11:58 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (10.44 KB, patch)
2019-04-15 11:15 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-12 11:35:29 PDT
# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Audit tab
3. download an audit
4. drag the downloaded Audit over the navigation sidebar
5. drop/release
 => the file moves back to finder like the drop was "rejected"
Comment 1 Radar WebKit Bug Importer 2019-04-12 11:35:45 PDT
<rdar://problem/49858190>
Comment 2 Devin Rousso 2019-04-12 11:58:23 PDT
Created attachment 367338 [details]
Patch
Comment 3 Timothy Hatcher 2019-04-15 10:10:44 PDT
Comment on attachment 367338 [details]
Patch

Nice!
Comment 4 WebKit Commit Bot 2019-04-15 10:28:11 PDT
Comment on attachment 367338 [details]
Patch

Rejecting attachment 367338 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 367338, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=367338&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=196873&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 367338 from bug 196873.
Fetching: https://bugs.webkit.org/attachment.cgi?id=367338
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 6 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebInspectorUI/UserInterface/Base/Main.js
Hunk #1 FAILED at 271.
Hunk #2 succeeded at 1524 with fuzz 1.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Base/Main.js.rej
patching file Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
patching file Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js
patching file Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js
patching file Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11872243
Comment 5 Devin Rousso 2019-04-15 11:15:17 PDT
Created attachment 367430 [details]
Patch
Comment 6 WebKit Commit Bot 2019-04-15 11:58:34 PDT
Comment on attachment 367430 [details]
Patch

Clearing flags on attachment: 367430

Committed r244278: <https://trac.webkit.org/changeset/244278>
Comment 7 WebKit Commit Bot 2019-04-15 11:58:36 PDT
All reviewed patches have been landed.  Closing bug.