Bug 196873 – Web Inspector: drag/drop over the sidebar should load an imported file in Canvas/Audit tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Audit tab
3. download an audit
4. drag the downloaded Audit over the navigation sidebar
5. drop/release
 => the file moves back to finder like the drop was "rejected"

[Radar WebKit Bug Importer]

<rdar://problem/49858190>

[Devin Rousso]

Created attachment 367338 [details]
Patch

[Timothy Hatcher]

Comment on attachment 367338 [details]
Patch

Nice!

[WebKit Commit Bot]

Comment on attachment 367338 [details]
Patch

Rejecting attachment 367338 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 367338, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=367338&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=196873&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 367338 from bug 196873.
Fetching: https://bugs.webkit.org/attachment.cgi?id=367338
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 6 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebInspectorUI/UserInterface/Base/Main.js
Hunk #1 FAILED at 271.
Hunk #2 succeeded at 1524 with fuzz 1.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Base/Main.js.rej
patching file Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
patching file Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js
patching file Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js
patching file Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11872243

[Devin Rousso]

Created attachment 367430 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367430 [details]
Patch

Clearing flags on attachment: 367430

Committed r244278: <https://trac.webkit.org/changeset/244278>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.