RESOLVED FIXED 196856
[ATK] Implement AtkComponentIface scroll_to methods 
https://bugs.webkit.org/show_bug.cgi?id=196856
Summary [ATK] Implement AtkComponentIface scroll_to methods
Carlos Garcia Campos
Reported 2019-04-12 05:07:44 PDT
There's scroll_to and scroll_to_point since ATK 2.30
Attachments
Patch (17.37 KB, patch)
2019-04-12 05:12 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (17.90 KB, patch)
2019-04-12 05:54 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (17.90 KB, patch)
2019-04-12 06:23 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Patch for landing (18.22 KB, patch)
2019-04-22 01:00 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.21 KB, patch)
2019-04-22 01:46 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-12 05:07:55 PDT
<rdar://problem/49848600>
Carlos Garcia Campos
Comment 2 2019-04-12 05:12:57 PDT
Created attachment 367315 [details] Patch
Carlos Garcia Campos
Comment 3 2019-04-12 05:54:34 PDT
Created attachment 367318 [details] Patch
Carlos Garcia Campos
Comment 4 2019-04-12 06:23:07 PDT
Created attachment 367320 [details] Patch
Michael Catanzaro
Comment 5 2019-04-12 09:01:29 PDT
Comment on attachment 367320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367320&action=review > Tools/gtk/jhbuild.modules:284 > + <meson id="atk" mesonargs="-Dintrospection=no"> meson.build:1:0: ERROR: Value no is not boolean (true or false). Needs to be =false, didn't you test this? > Tools/gtk/jhbuild.modules:290 > + <meson id="at-spi2-core" mesonargs="-Dintrospection=no"> Ditto
Carlos Garcia Campos
Comment 6 2019-04-22 01:00:52 PDT
Created attachment 367927 [details] Patch for landing
Carlos Garcia Campos
Comment 7 2019-04-22 01:43:53 PDT
(In reply to Michael Catanzaro from comment #5) > Comment on attachment 367320 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367320&action=review > > > Tools/gtk/jhbuild.modules:284 > > + <meson id="atk" mesonargs="-Dintrospection=no"> > > meson.build:1:0: ERROR: Value no is not boolean (true or false). > > Needs to be =false, didn't you test this? meson.build:1:0: ERROR: Value "false" for combo option "introspection" is not one of the choices. Possible choices are: "yes", "no", "auto". > > Tools/gtk/jhbuild.modules:290 > > + <meson id="at-spi2-core" mesonargs="-Dintrospection=no"> > > Ditto
Carlos Garcia Campos
Comment 8 2019-04-22 01:46:27 PDT
Created attachment 367928 [details] Patch for landing
WebKit Commit Bot
Comment 9 2019-04-23 03:47:51 PDT
Comment on attachment 367928 [details] Patch for landing Clearing flags on attachment: 367928 Committed r244538: <https://trac.webkit.org/changeset/244538>
WebKit Commit Bot
Comment 10 2019-04-23 03:47:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.