Bug 196833 - Update 'Save Image' to more clear instructions
Summary: Update 'Save Image' to more clear instructions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-11 15:28 PDT by Megan Gardner
Modified: 2019-04-12 14:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.91 KB, patch)
2019-04-11 15:33 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (4.07 KB, patch)
2019-04-11 15:50 PDT, Megan Gardner
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch (3.20 KB, patch)
2019-04-11 16:06 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-04-11 15:28:30 PDT
Update 'Save Image' to more clear instructions
Comment 1 Megan Gardner 2019-04-11 15:33:28 PDT
Created attachment 367253 [details]
Patch
Comment 2 Megan Gardner 2019-04-11 15:33:52 PDT
<rdar://problem/47446845>
Comment 3 Wenson Hsieh 2019-04-11 15:42:38 PDT
Comment on attachment 367253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review

> Source/WebCore/en.lproj/Localizable.strings:629
> -/* Title for Save Image action button */
> -"Save Image" = "Save Image";
> +/* Title for Add to Photos action button */
> +"Add to Photos" = "Add to Photos";

I think these are in sorted order. IIRC, Tools/Scripts/update-webkit-localizable-strings should do the trick.

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95
> +localizedStrings["Add to Photos"] = "Add to Photos";

Is this related? I think this is a separate web inspector feature...

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:951
> +        contextMenu.appendItem(WI.UIString("Add to Photos"), () => {

(Here too)
Comment 4 Wenson Hsieh 2019-04-11 15:45:08 PDT
Comment on attachment 367253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95
>> +localizedStrings["Add to Photos"] = "Add to Photos";
> 
> Is this related? I think this is a separate web inspector feature...

This is the feature Devin added in WI that allows us to snapshot a DOM node. We don't want to change this string.
Comment 5 Megan Gardner 2019-04-11 15:50:33 PDT
Created attachment 367254 [details]
Patch
Comment 6 Wenson Hsieh 2019-04-11 15:52:18 PDT
Comment on attachment 367254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367254&action=review

> Source/WebInspectorUI/ChangeLog:15
> +

Let's remove this ChangeLog entry.
Comment 7 Megan Gardner 2019-04-11 16:06:16 PDT
Created attachment 367258 [details]
Patch
Comment 8 Megan Gardner 2019-04-11 16:06:47 PDT
Sorry, I meant to, I guess I missed it.
Comment 9 WebKit Commit Bot 2019-04-11 17:58:56 PDT
Comment on attachment 367258 [details]
Patch

Clearing flags on attachment: 367258

Committed r244205: <https://trac.webkit.org/changeset/244205>