Bug 196833 – Update 'Save Image' to more clear instructions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Update 'Save Image' to more clear instructions

[Megan Gardner]

Created attachment 367253 [details]
Patch

[Megan Gardner]

<rdar://problem/47446845>

[Wenson Hsieh]

Comment on attachment 367253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review

> Source/WebCore/en.lproj/Localizable.strings:629
> -/* Title for Save Image action button */
> -"Save Image" = "Save Image";
> +/* Title for Add to Photos action button */
> +"Add to Photos" = "Add to Photos";

I think these are in sorted order. IIRC, Tools/Scripts/update-webkit-localizable-strings should do the trick.

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95
> +localizedStrings["Add to Photos"] = "Add to Photos";

Is this related? I think this is a separate web inspector feature...

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:951
> +        contextMenu.appendItem(WI.UIString("Add to Photos"), () => {

(Here too)

[Wenson Hsieh]

Comment on attachment 367253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95
>> +localizedStrings["Add to Photos"] = "Add to Photos";
> 
> Is this related? I think this is a separate web inspector feature...

This is the feature Devin added in WI that allows us to snapshot a DOM node. We don't want to change this string.

[Megan Gardner]

Created attachment 367254 [details]
Patch

[Wenson Hsieh]

Comment on attachment 367254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367254&action=review

> Source/WebInspectorUI/ChangeLog:15
> +

Let's remove this ChangeLog entry.

[Megan Gardner]

Created attachment 367258 [details]
Patch

[Megan Gardner]

Sorry, I meant to, I guess I missed it.

[WebKit Commit Bot]

Comment on attachment 367258 [details]
Patch

Clearing flags on attachment: 367258

Committed r244205: <https://trac.webkit.org/changeset/244205>