RESOLVED FIXED 196832
Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot 
https://bugs.webkit.org/show_bug.cgi?id=196832
Summary Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot
Devin Rousso
Reported 2019-04-11 15:22:43 PDT
# STEPS TO REPRODUCE: 1. inspect any page 2. go to the Timelines tab 3. enable the JavaScript Allocations timeline 4. select the JavaScript Allocations timeline 5. take a heap snapshot
Attachments
Patch (1.79 KB, patch)
2019-04-11 15:23 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.98 KB, patch)
2019-04-11 15:29 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-04-11 15:22:56 PDT
<rdar://problem/49828862>
Devin Rousso
Comment 2 2019-04-11 15:23:28 PDT
Created attachment 367249 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-04-11 15:27:32 PDT
Comment on attachment 367249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367249&action=review > Source/WebInspectorUI/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + * UserInterface/Controllers/TimelineManager.js: Word here please like "This regressed when I discombobulated the rotary encabulator".
Devin Rousso
Comment 4 2019-04-11 15:29:52 PDT
Created attachment 367251 [details] Patch
WebKit Commit Bot
Comment 5 2019-04-11 15:56:45 PDT
Comment on attachment 367251 [details] Patch Clearing flags on attachment: 367251 Committed r244199: <https://trac.webkit.org/changeset/244199>
WebKit Commit Bot
Comment 6 2019-04-11 15:56:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.