Bug 196832 - Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot
Summary: Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-11 15:22 PDT by Devin Rousso
Modified: 2019-04-11 15:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2019-04-11 15:23 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2019-04-11 15:29 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-11 15:22:43 PDT 
# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Timelines tab
3. enable the JavaScript Allocations timeline
4. select the JavaScript Allocations timeline
5. take a heap snapshot
Comment 1 Devin Rousso 2019-04-11 15:22:56 PDT 
<rdar://problem/49828862>
Comment 2 Devin Rousso 2019-04-11 15:23:28 PDT 
Created attachment 367249 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-04-11 15:27:32 PDT 
Comment on attachment 367249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367249&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UserInterface/Controllers/TimelineManager.js:

Word here please like "This regressed when I discombobulated the rotary encabulator".
Comment 4 Devin Rousso 2019-04-11 15:29:52 PDT 
Created attachment 367251 [details]
Patch
Comment 5 WebKit Commit Bot 2019-04-11 15:56:45 PDT 
Comment on attachment 367251 [details]
Patch

Clearing flags on attachment: 367251

Committed r244199: <https://trac.webkit.org/changeset/244199>
Comment 6 WebKit Commit Bot 2019-04-11 15:56:47 PDT 
All reviewed patches have been landed.  Closing bug.