Bug 196822 - Extract UTI mapping and allow for additions
Summary: Extract UTI mapping and allow for additions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-11 12:08 PDT by Dean Jackson
Modified: 2019-04-14 13:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (16.33 KB, patch)
2019-04-11 12:13 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (7.68 KB, patch)
2019-04-11 15:04 PDT, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-04-11 12:08:02 PDT
Extract UTI mapping and allow for additions
Comment 1 Radar WebKit Bug Importer 2019-04-11 12:08:32 PDT
<rdar://problem/49822339>
Comment 2 Dean Jackson 2019-04-11 12:13:17 PDT
Created attachment 367231 [details]
Patch
Comment 3 Tim Horton 2019-04-11 12:15:35 PDT
Comment on attachment 367231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367231&action=review

> Source/WebKit/Shared/ios/UTIMappings.mm:42
> +NSString *UTIforMIMEType(const String& mimeType)

Seems like this should fold into UTIUtilities
Comment 4 Dean Jackson 2019-04-11 15:04:39 PDT
Created attachment 367247 [details]
Patch
Comment 5 Tim Horton 2019-04-11 15:20:00 PDT
Comment on attachment 367247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367247&action=review

> Source/WebCore/platform/network/mac/UTIUtilities.mm:89
> +    static const auto map = makeNeverDestroyed([] {

Why not just go straight to UTI instead of using CoreServices, if you're already hardcoding?
Comment 6 Dean Jackson 2019-04-11 16:13:55 PDT
Committed r244201: <https://trac.webkit.org/changeset/244201>
Comment 7 Darin Adler 2019-04-12 09:12:21 PDT
Comment on attachment 367247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367247&action=review

> Source/WebCore/platform/network/mac/UTIUtilities.mm:112
> +    return String(adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassFilenameExtension, mapEntry->value.createCFString().get(), nil)).get());

I don’t think the explicit String constructor is needed here.

> Source/WebCore/platform/network/mac/UTIUtilities.mm:121
> +            return String(type.get());

I don’t think the explicit String constructor is needed here.
Comment 8 Dean Jackson 2019-04-14 13:14:28 PDT
Committed r244247: <https://trac.webkit.org/changeset/244247>
Comment 9 Dean Jackson 2019-04-14 13:14:54 PDT
Comment on attachment 367247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367247&action=review

>> Source/WebCore/platform/network/mac/UTIUtilities.mm:121
>> +            return String(type.get());
> 
> I don’t think the explicit String constructor is needed here.

Fixed.