Bug 196817 - [GTK][WPE] Fix pacman install-dependencies packages
Summary: [GTK][WPE] Fix pacman install-dependencies packages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-11 06:30 PDT by Ludovico de Nittis
Modified: 2019-04-12 06:30 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2019-04-11 06:39 PDT, Ludovico de Nittis
no flags Details | Formatted Diff | Diff
Patch (2.94 KB, patch)
2019-04-11 06:42 PDT, Claudio Saavedra
no flags Details | Formatted Diff | Diff
Patch (3.64 KB, patch)
2019-04-11 06:53 PDT, Ludovico de Nittis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ludovico de Nittis 2019-04-11 06:30:10 PDT
Trying to install the WebKit dependencies on Arch Linux I found the following errors:

- `python3-setuptools` is actually called `python-setuptools`.

- `ruby-highline` is only available on AUR and not in the official repositories.

- `libv4l-devel` is incorporated in `v4l-utils`.
Comment 1 Ludovico de Nittis 2019-04-11 06:39:01 PDT
Created attachment 367215 [details]
Patch
Comment 2 Claudio Saavedra 2019-04-11 06:42:15 PDT
Created attachment 367216 [details]
Patch
Comment 3 Claudio Saavedra 2019-04-11 06:43:37 PDT
Comment on attachment 367216 [details]
Patch

Sorry, I didn't realize you were going to submit a patch as well.
Comment 4 Claudio Saavedra 2019-04-11 06:45:58 PDT
Comment on attachment 367215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367215&action=review

> Tools/wpe/install-dependencies:194
> +    # Note: apache-mod_bw, ruby-json and ruby-highline are available in the AUR

If you look at the wpe script, there is a long explanation on how to get packages from AUR. Please bring this script in sync with that one (as I had done in mine).
Comment 5 Claudio Saavedra 2019-04-11 06:46:28 PDT
(In reply to Claudio Saavedra from comment #4)
> Comment on attachment 367215 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367215&action=review
> 
> > Tools/wpe/install-dependencies:194
> > +    # Note: apache-mod_bw, ruby-json and ruby-highline are available in the AUR
> 
> If you look at the wpe script, there is a long explanation on how to get
> packages from AUR. Please bring this script in sync with that one (as I had
> done in mine).

Not my day, it seems. I meant the gtk script.
Comment 6 Ludovico de Nittis 2019-04-11 06:53:01 PDT
Created attachment 367217 [details]
Patch
Comment 7 Ludovico de Nittis 2019-04-11 06:53:50 PDT
Don't worry Claudio, I wasn't expecting someone to issue a patch in just 10 minutes :)
Comment 8 Claudio Saavedra 2019-04-12 00:22:03 PDT
lgtm
Comment 9 WebKit Commit Bot 2019-04-12 06:29:47 PDT
Comment on attachment 367217 [details]
Patch

Clearing flags on attachment: 367217

Committed r244214: <https://trac.webkit.org/changeset/244214>
Comment 10 WebKit Commit Bot 2019-04-12 06:29:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-04-12 06:30:20 PDT
<rdar://problem/49849756>