RESOLVED FIXED 196814
[MotionMark] The text "kkkj" is causing Firefox console warning: `unreachable code after return statement` 
https://bugs.webkit.org/show_bug.cgi?id=196814
Summary [MotionMark] The text "kkkj" is causing Firefox console warning: `unreachable...
kUVoxnV8F4Qp
Reported 2019-04-11 04:34:20 PDT
See https://github.com/WebKit/webkit/search?utf8=%E2%9C%93&q=kkkj&type= or: $ grep -nrIFw kkkj Websites/browserbench.org/MotionMark1.1/resources/extensions.js:403: return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj Websites/browserbench.org/MotionMark/resources/extensions.js:374: return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj PerformanceTests/MotionMark/resources/extensions.js:403: return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj This looks like navigation text from an editor(like vim, emacs) where pressing 'k' causes cursor to go up one line, 'j' is go down one line, 'l' is go right one char and 'h' is go left one char.
Attachments
Patch (3.94 KB, patch)
2019-04-15 11:04 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-11 20:24:18 PDT
<rdar://problem/49839036>
Said Abou-Hallawa
Comment 2 2019-04-12 18:02:51 PDT
This gibberish was added in <http://trac.webkit.org/changeset/197908>.
Jon Lee
Comment 3 2019-04-12 18:54:05 PDT
-_____-
Jon Lee
Comment 4 2019-04-15 11:04:14 PDT
Created attachment 367428 [details] Patch
Wenson Hsieh
Comment 5 2019-04-15 11:07:21 PDT
Comment on attachment 367428 [details] Patch rs=me
WebKit Commit Bot
Comment 6 2019-04-16 13:52:26 PDT
Comment on attachment 367428 [details] Patch Clearing flags on attachment: 367428 Committed r244357: <https://trac.webkit.org/changeset/244357>
WebKit Commit Bot
Comment 7 2019-04-16 13:52:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.