Bug 196814 - [MotionMark] The text "kkkj" is causing Firefox console warning: `unreachable code after return statement`
Summary: [MotionMark] The text "kkkj" is causing Firefox console warning: `unreachable...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Trivial
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-11 04:34 PDT by kUVoxnV8F4Qp
Modified: 2019-04-16 13:52 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.94 KB, patch)
2019-04-15 11:04 PDT, Jon Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kUVoxnV8F4Qp 2019-04-11 04:34:20 PDT
See https://github.com/WebKit/webkit/search?utf8=%E2%9C%93&q=kkkj&type=
or:
$ grep -nrIFw kkkj
Websites/browserbench.org/MotionMark1.1/resources/extensions.js:403:        return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj
Websites/browserbench.org/MotionMark/resources/extensions.js:374:        return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj
PerformanceTests/MotionMark/resources/extensions.js:403:        return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj

This looks like navigation text from an editor(like vim, emacs) where pressing 'k' causes cursor to go up one line, 'j' is go down one line, 'l' is go right one char and 'h' is go left one char.
Comment 1 Radar WebKit Bug Importer 2019-04-11 20:24:18 PDT
<rdar://problem/49839036>
Comment 2 Said Abou-Hallawa 2019-04-12 18:02:51 PDT
This gibberish was added in <http://trac.webkit.org/changeset/197908>.
Comment 3 Jon Lee 2019-04-12 18:54:05 PDT
-_____-
Comment 4 Jon Lee 2019-04-15 11:04:14 PDT
Created attachment 367428 [details]
Patch
Comment 5 Wenson Hsieh 2019-04-15 11:07:21 PDT
Comment on attachment 367428 [details]
Patch

rs=me
Comment 6 WebKit Commit Bot 2019-04-16 13:52:26 PDT
Comment on attachment 367428 [details]
Patch

Clearing flags on attachment: 367428

Committed r244357: <https://trac.webkit.org/changeset/244357>
Comment 7 WebKit Commit Bot 2019-04-16 13:52:27 PDT
All reviewed patches have been landed.  Closing bug.