WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196812
Ensure iOS layout traits are used for media controls in modern compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=196812
Summary
Ensure iOS layout traits are used for media controls in modern compatibility ...
Antoine Quint
Reported
2019-04-11 01:51:10 PDT
Currently we are using the macOS ones but we should use the iOS ones.
Attachments
Patch
(5.14 KB, patch)
2019-04-11 01:54 PDT
,
Antoine Quint
dino
: review+
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2
(9.50 MB, application/zip)
2019-04-11 03:52 PDT
,
EWS Watchlist
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2019-04-11 01:51:23 PDT
<
rdar://problem/47460637
>
Antoine Quint
Comment 2
2019-04-11 01:54:02 PDT
Created
attachment 367211
[details]
Patch
EWS Watchlist
Comment 3
2019-04-11 03:52:57 PDT
Comment on
attachment 367211
[details]
Patch
Attachment 367211
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/11839482
New failing tests: media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button.html media/video-fullscreen-reload-crash.html media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html
EWS Watchlist
Comment 4
2019-04-11 03:52:58 PDT
Created
attachment 367212
[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Antoine Quint
Comment 5
2019-04-15 00:06:52 PDT
I don't understand the failures as reported by EWS, and installing a configuration similar to the bot that reported the failure doesn't reproduce. I'm going to land this as-is and take a look at the other bots.
Antoine Quint
Comment 6
2019-04-15 00:11:37 PDT
Committed
r244253
: <
https://trac.webkit.org/changeset/244253
>
Antoine Quint
Comment 7
2019-04-15 04:49:37 PDT
Committed
r244259
: <
https://trac.webkit.org/changeset/244259
>
Antoine Quint
Comment 8
2019-04-15 04:53:45 PDT
I landed a speculative fix for the bot failures. I think the reason was that we used to have a platform-based check and this patch switched to one based on feature-discovery. Prior to this patch, we'd use the macOS layout traits if navigator.platform === "MacIntel" and the iOS traits otherwise. With this patch, we use the iOS layout traits if touch events are supported and macOS otherwise. I think this led the open-source iOS bots to using the macOS layout traits since touch events aren't support, or at least not advertised using `createTouch in document`. So my speculative fix is to use iOS if either we support touches or navigator.platform !== "MacIntel". Hopefully this will address the bot issues.
Antoine Quint
Comment 9
2019-04-15 05:51:06 PDT
The speculative fix looks solid, bots look happy.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug