Bug 196809 - WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
Summary: WKNavigationResponse._downloadAttribute should be nil when no download attrib...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 196806 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-04-10 22:35 PDT by Alex Christensen
Modified: 2019-04-11 08:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.92 KB, patch)
2019-04-10 22:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-04-10 22:35:31 PDT 
WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
Comment 1 Alex Christensen 2019-04-10 22:37:14 PDT 
Created attachment 367205 [details]
Patch
Comment 2 David Quesada 2019-04-10 22:54:21 PDT 
*** Bug 196806 has been marked as a duplicate of this bug. ***
Comment 3 WebKit Commit Bot 2019-04-10 23:16:06 PDT 
Comment on attachment 367205 [details]
Patch

Clearing flags on attachment: 367205

Committed r244184: <https://trac.webkit.org/changeset/244184>
Comment 4 WebKit Commit Bot 2019-04-10 23:16:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-10 23:17:19 PDT 
<rdar://problem/49803597>
Comment 6 Darin Adler 2019-04-11 08:50:40 PDT 
Comment on attachment 367205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367205&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKNavigationResponse.mm:84
> -    return _navigationResponse->downloadAttribute();
> +    const String& attribute = _navigationResponse->downloadAttribute();
> +    return attribute.isNull() ? nil : (NSString *)attribute;

The function nsStringNilIfEmpty from WTFString.h was designed for uses like this one. I admit it does not have a beautiful name, but this is exactly what it’s for.
Comment 7 Darin Adler 2019-04-11 08:51:13 PDT 
Comment on attachment 367205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367205&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKNavigationResponse.mm:84
>> +    return attribute.isNull() ? nil : (NSString *)attribute;
> 
> The function nsStringNilIfEmpty from WTFString.h was designed for uses like this one. I admit it does not have a beautiful name, but this is exactly what it’s for.

Oops, no, this is "nil if null", which is not the same thing. Sorry.