Bug 196791 – [GTK] REGRESSION(r243860): Many tests failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alicia Boya García]

compositing/backing/backing-store-attachment-empty-keyframe.html is failing since r243860

I'm tempted to just rebaseline, but I'm not really sure, since the patch is not touching the test at all and it did share expectations with the Mac port without issues.

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/scrolling/scroll-animator-basic-events-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/scrolling/scroll-animator-basic-events-actual.txt
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 24: MainFrameView: didAddVerticalScrollbar
-CONSOLE MESSAGE: line 24: RenderLayer: didAddVerticalScrollbar
+CONSOLE MESSAGE: MainFrameView: didAddVerticalScrollbar
+CONSOLE MESSAGE: RenderLayer: didAddVerticalScrollbar
 CONSOLE MESSAGE: line 24: MainFrameView: mouseEnteredContentArea
 CONSOLE MESSAGE: line 24: MainFrameView: mouseMovedInContentArea
 CONSOLE MESSAGE: line 25: RenderLayer: mouseEnteredContentArea

[Alicia Boya García]

I kept experimenting with the bisection and found that almost all of the failures from the r243859:r243864 build are regressions from this revision.

Some of them show visible layout changes.

Non comprehensive list of tests failing:

tables/mozilla/dom/deleteCol1.html
tables/mozilla/dom/deleteCol2.html
tables/mozilla/dom/deleteCol3.html
tables/mozilla/dom/deleteColGroup1.html
tables/mozilla/dom/deleteColGroup2.html
tables/mozilla/dom/insertColGroups1.html
tables/mozilla/dom/insertColGroups2.html
tables/mozilla/dom/insertCols1.html
tables/mozilla/dom/insertCols2.html
tables/mozilla/dom/insertCols3.html
tables/mozilla/dom/insertCols4.html
tables/mozilla/dom/insertCols5.html
svg/hixie/text/003.html
svg/custom/linking-uri-01-b.svg
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px.html
fast/text/international/bidi-listbox-atsui.html
fast/text/international/bidi-innertext.html
fast/text/international/bidi-L2-run-reordering.html
fast/scrolling/scroll-animator-select-list-events.html
fast/scrolling/scroll-animator-overlay-scrollbars-hovered.html
fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html
fast/scrolling/scroll-animator-basic-events.html
fast/frames/inline-object-inside-frameset.html
fast/frames/crash-when-iframe-is-remove-in-eventhandler.html
fast/forms/visual-hebrew-text-field.html
fast/forms/select-visual-hebrew.html
fast/forms/form-submission-crash-3.html
compositing/backing/backing-store-attachment-empty-keyframe.html

[Alicia Boya García]

These tests are also failing, bisected to the same revision:

fast/images/animated-gif-no-layout.html
http/tests/incremental/stylesheet-body-incremental-rendering.html
http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html
mathml/scripts-removeChild.html
mathml/presentation/attributes-accent-accentunder-dynamic.html
mathml/presentation/menclose-notation-attribute-add.html
mathml/presentation/menclose-notation-attribute-change-value.html
mathml/presentation/menclose-notation-attribute-remove.html
mathml/presentation/mo-form-dynamic.html
mathml/presentation/mpadded-dynamic.html
mathml/presentation/stretchy-minsize-maxsize-dynamic.html
svg/custom/textPath-change-id-pattern.svg
svg/custom/textPath-change-id.svg
svg/custom/textPath-insert-path-pattern.svg
svg/custom/textPath-insert-path.svg

[Michael Catanzaro]

Carlos, this was the window object cleared patch.

(In reply to Alicia Boya García from comment #0)
> I'm tempted to just rebaseline, but I'm not really sure, since the patch is
> not touching the test at all and it did share expectations with the Mac port
> without issues.

Not rebaselining is probably the right choice as that patch should not have affected other than accessibility.

[Carlos Garcia Campos]

Created attachment 367221 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367221 [details]
Patch

Rejecting attachment 367221 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 367221, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=367221&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=196791&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 367221 from bug 196791.
Fetching: https://bugs.webkit.org/attachment.cgi?id=367221
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/gtk/TestExpectations
	M	Source/WebKit/ChangeLog
	M	Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
	M	Source/WebKit/WebProcess/WebPage/WebPage.h
	M	Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp
	M	Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.h
	M	Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp
	M	Tools/ChangeLog
	M	Tools/TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp
	M	Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
W: 8955ccac4cdde125206c6025f2ccb07c4cb53fc8 and refs/remotes/origin/master differ, using rebase:
:040000 040000 76964240a41fea055e77d8eea0a65b81407b8164 3cf0915953c83233f1ab21e95d854adde8e1059b M	LayoutTests
:040000 040000 9359580af33d418ac607366c9ce8bc370f00fad5 5f4a017abf698134231f6024c6b9e25c9337824c M	Source
:040000 040000 2574c2cb30011164eed025e0fba32b016923f02b 249250c8dca3dc7c215b0e3851f993581583182a M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/gtk/TestExpectations
	M	Source/WebKit/ChangeLog
	M	Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
	M	Source/WebKit/WebProcess/WebPage/WebPage.h
	M	Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp
	M	Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.h
	M	Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp
	M	Tools/ChangeLog
	M	Tools/TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp
	M	Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
W: 8955ccac4cdde125206c6025f2ccb07c4cb53fc8 and refs/remotes/origin/master differ, using rebase:
:040000 040000 76964240a41fea055e77d8eea0a65b81407b8164 3cf0915953c83233f1ab21e95d854adde8e1059b M	LayoutTests
:040000 040000 9359580af33d418ac607366c9ce8bc370f00fad5 5f4a017abf698134231f6024c6b9e25c9337824c M	Source
:040000 040000 2574c2cb30011164eed025e0fba32b016923f02b 249250c8dca3dc7c215b0e3851f993581583182a M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.
Total errors found: 0 in 1 files

Full output: https://webkit-queues.webkit.org/results/11851652

[Carlos Garcia Campos]

Committed r244212: <https://trac.webkit.org/changeset/244212>