Bug 196777 - Unable to run system Safari with trunk WebKit
Summary: Unable to run system Safari with trunk WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, NeedsReduction
Depends on:
Blocks:
 
Reported: 2019-04-10 11:59 PDT by Chris Dumez
Modified: 2019-04-11 16:43 PDT (History)
9 users (show)

See Also:


Attachments
Patch (7.44 KB, patch)
2019-04-10 12:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.46 KB, patch)
2019-04-10 13:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (14.31 KB, patch)
2019-04-10 20:47 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (14.28 KB, patch)
2019-04-10 21:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.42 KB, patch)
2019-04-10 22:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.74 MB, application/zip)
2019-04-11 00:05 PDT, Build Bot
no flags Details
Patch (10.75 KB, patch)
2019-04-11 14:57 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-04-10 11:59:15 PDT
Unable to run system Safari with trunk WebKit:
SafariForWebKitDevelopment[644:9602] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Related web view <WKWebView: 0x7fbc8752ce00> has data store <WKWebsiteDataStore: 0x7fbc872856e0> but configuration specifies a different data store <WKWebsiteDataStore: 0x7fbc87562590>'
Comment 1 Radar WebKit Bug Importer 2019-04-10 12:00:03 PDT
<rdar://problem/49784574>
Comment 2 Chris Dumez 2019-04-10 12:33:22 PDT
Created attachment 367147 [details]
Patch
Comment 3 Alex Christensen 2019-04-10 13:06:34 PDT
Comment on attachment 367147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367147&action=review

> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:46
> +#define DYLD_MACOS_VERSION_FIRST_WITH_EXCEPTIONS_FOR_RELATED_WEBVIEWS_USING_DIFFERENT_DATA_STORES 0

I don't think this will fix our open source friends' problem.  We need to define the last version and use DYLD_MACOSX_VERSION_10_14

> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:86
> +enum class AssumeSafariIsAlwaysLinkedOnAfter { No, Yes };

: bool
Comment 4 Chris Dumez 2019-04-10 13:07:56 PDT
(In reply to Alex Christensen from comment #3)
> Comment on attachment 367147 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367147&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:46
> > +#define DYLD_MACOS_VERSION_FIRST_WITH_EXCEPTIONS_FOR_RELATED_WEBVIEWS_USING_DIFFERENT_DATA_STORES 0
> 
> I don't think this will fix our open source friends' problem.  We need to
> define the last version and use DYLD_MACOSX_VERSION_10_14

I believe it works because of the change I made to linkedOnAfter which special-cases 0 as sdkVersion.

> 
> > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:86
> > +enum class AssumeSafariIsAlwaysLinkedOnAfter { No, Yes };
> 
> : bool
Comment 5 Chris Dumez 2019-04-10 13:08:31 PDT
(In reply to Chris Dumez from comment #4)
> (In reply to Alex Christensen from comment #3)
> > Comment on attachment 367147 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=367147&action=review
> > 
> > > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:46
> > > +#define DYLD_MACOS_VERSION_FIRST_WITH_EXCEPTIONS_FOR_RELATED_WEBVIEWS_USING_DIFFERENT_DATA_STORES 0
> > 
> > I don't think this will fix our open source friends' problem.  We need to
> > define the last version and use DYLD_MACOSX_VERSION_10_14
> 
> I believe it works because of the change I made to linkedOnAfter which
> special-cases 0 as sdkVersion.

As it is working for me without internal changes.
Comment 6 Chris Dumez 2019-04-10 13:09:30 PDT
Created attachment 367149 [details]
Patch
Comment 7 Chris Dumez 2019-04-10 13:10:09 PDT
Comment on attachment 367149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367149&action=review

> Source/WebKit/ChangeLog:20
> +        - In the header, DYLD_IOS_VERSION_* / DYLD_MACOS_VERSION_* constants are 0 when building with the

I explained this in the Changelog here.
Comment 8 WebKit Commit Bot 2019-04-10 13:44:39 PDT
Comment on attachment 367149 [details]
Patch

Clearing flags on attachment: 367149

Committed r244146: <https://trac.webkit.org/changeset/244146>
Comment 9 WebKit Commit Bot 2019-04-10 13:44:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Chris Dumez 2019-04-10 16:57:36 PDT
Reverted r244146 for reason:

Caused a few DeviceOrientation API test failures on iOS

Committed r244170: <https://trac.webkit.org/changeset/244170>
Comment 11 Chris Dumez 2019-04-10 20:47:11 PDT
Created attachment 367196 [details]
Patch
Comment 12 Chris Dumez 2019-04-10 21:10:19 PDT
Created attachment 367199 [details]
Patch
Comment 13 Chris Dumez 2019-04-10 22:10:38 PDT
Created attachment 367202 [details]
Patch
Comment 14 Build Bot 2019-04-11 00:05:29 PDT
Comment on attachment 367202 [details]
Patch

Attachment 367202 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11838498

New failing tests:
fast/device-orientation/device-orientation-request-permission-granted.html
fast/device-orientation/device-motion-request-permission-denied.html
fast/device-orientation/device-motion-request-permission-granted.html
fast/device-orientation/device-orientation-request-permission-user-gesture.html
http/tests/events/device-orientation-motion-secure-context.html
fast/device-orientation/device-orientation-request-permission-denied.html
fast/device-orientation/device-motion-request-permission-user-gesture.html
Comment 15 Build Bot 2019-04-11 00:05:31 PDT
Created attachment 367208 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 16 Chris Dumez 2019-04-11 14:57:23 PDT
Created attachment 367246 [details]
Patch
Comment 17 WebKit Commit Bot 2019-04-11 16:43:16 PDT
Comment on attachment 367246 [details]
Patch

Clearing flags on attachment: 367246

Committed r244203: <https://trac.webkit.org/changeset/244203>
Comment 18 WebKit Commit Bot 2019-04-11 16:43:17 PDT
All reviewed patches have been landed.  Closing bug.