WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
19677
Syntax highlighting JavaScript needs to be lazy
https://bugs.webkit.org/show_bug.cgi?id=19677
Summary
Syntax highlighting JavaScript needs to be lazy
Timothy Hatcher
Reported
2008-06-19 10:36:57 PDT
The new syntax highlighting is written in JavaScript and can be slow for large documents. We should make is lazy and only syntax highlight visible lines of code and delays the rest until the user scrolls down. Some of the work to make this lazy has already been done in the original patch. Related to
bug 14360
.
Attachments
Proposed patch
(4.55 KB, patch)
2008-06-20 11:22 PDT
,
Timothy Hatcher
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2008-06-20 11:22:50 PDT
Created
attachment 21858
[details]
Proposed patch
Adam Roben (:aroben)
Comment 2
2008-06-20 11:29:25 PDT
Comment on
attachment 21858
[details]
Proposed patch + if (i < (end - 1)) + deleteContinueFlags(previousCell); I think if (i > 0) would be clearer here. r=me
Adam Roben (:aroben)
Comment 3
2008-06-20 11:32:47 PDT
(In reply to
comment #2
)
> (From update of
attachment 21858
[details]
[edit]) > + if (i < (end - 1)) > + deleteContinueFlags(previousCell); > > I think if (i > 0) would be clearer here.
...and more correct.
Timothy Hatcher
Comment 4
2008-06-20 15:22:28 PDT
Landed in
r34695
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug