Bug 196765 - [GStreamer] Adaptive streaming playback broken with GStreamer < 1.12
Summary: [GStreamer] Adaptive streaming playback broken with GStreamer < 1.12
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-10 01:33 PDT by Philippe Normand
Modified: 2019-04-10 02:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.62 KB, patch)
2019-04-10 01:40 PDT, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-04-10 01:33:39 PDT 
GStreamer < 1.12 has an incomplete uridownloader implementation so we
can't use WebKitWebSrc for adaptive fragments downloading if this
version is detected.
Comment 1 Philippe Normand 2019-04-10 01:40:24 PDT 
Created attachment 367110 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2019-04-10 02:09:15 PDT 
Comment on attachment 367110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367110&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:907
> +    m_origins.add(WTFMove(origin));

Please, collapse these two lines:

m_origins.add(SecurityOrigin::create(response.url()));
Comment 3 Philippe Normand 2019-04-10 02:14:35 PDT 
Committed r244109: <https://trac.webkit.org/changeset/244109>
Comment 4 Radar WebKit Bug Importer 2019-04-10 02:15:19 PDT 
<rdar://problem/49768460>