Bug 196762 – WebCore should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ross Kirsling]

WebCore should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF

[Ross Kirsling]

Created attachment 367102 [details]
Patch

[Ross Kirsling]

Comment on attachment 367102 [details]
Patch

The good news is that this patch gets WinCairo (regardless of clang-cl or regular cl) through compiling WebCore.

The bad news is that we hit one heck of a nasty-looking linking error:

> [5/1068] Linking CXX static library lib64\WebCore.lib
> FAILED: lib64/WebCore.lib
> cmd.exe /C "cd . && C:\PROGRA~2\MICROS~4\2019\COMMUN~1\VC\Tools\MSVC\1420~1.275\bin\Hostx64\x64\link.exe /lib /nologo /machine:x64 /out:lib64\WebCore.lib @CMakeFiles\WebCore.rsp  && cd ."
> lib64\WebCore.lib : fatal error LNK1248: image size (1002E82C0) exceeds maximum allowable size (FFFFFFFF)
> ninja: build stopped: subcommand failed.

[EWS Watchlist]

Comment on attachment 367102 [details]
Patch

Attachment 367102 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11826610

New failing tests:
fast/dom/gc-9.html

[EWS Watchlist]

Created attachment 367106 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 367102 [details]
Patch

Attachment 367102 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11826593

New failing tests:
fast/dom/gc-9.html

[EWS Watchlist]

Created attachment 367107 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Ross Kirsling]

Created attachment 367108 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 367108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367108&action=review

r=me provided the following comments are addressed.

> Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:31
> +    JSCanvasRenderingContext2D* jsCanvasRenderingContext = JSC::jsCast<JSCanvasRenderingContext2D*>(handle.slot()->asCell());
> +    void* root = jsCanvasRenderingContext->wrapped().canvas().opaqueRoot();

We don't wanna directly call Node::opaqueRoot like this.
Just include JSNode.h instead.

> Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:37
> -    visitor.addOpaqueRoot(root(wrapped().canvas()));
> +    visitor.addOpaqueRoot(wrapped().canvas().opaqueRoot());

Ditto.

[Ryosuke Niwa]

JSNodeCustom.h rather.

[Ross Kirsling]

Created attachment 367127 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 367127 [details]
Patch for landing

Clearing flags on attachment: 367127

Committed r244115: <https://trac.webkit.org/changeset/244115>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49779064>