Bug 19676 - [Gtk] text-shadow should apply to text decorations as well
Summary: [Gtk] text-shadow should apply to text decorations as well
Status: RESOLVED DUPLICATE of bug 48074
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-06-19 09:50 PDT by Jonathon Jongsma (jonner)
Modified: 2010-11-27 08:21 PST (History)
1 user (show)

See Also:

Attachments
patch to implement drawing shadows for lines (2.02 KB, patch)
2008-06-19 13:36 PDT, Jonathon Jongsma (jonner) 		no flags Details | Formatted Diff | Diff
Updated patch due to changes from bug #19727 (1.86 KB, patch)
2008-06-24 12:59 PDT, Jonathon Jongsma (jonner) 		eric: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathon Jongsma (jonner) 2008-06-19 09:50:18 PDT 
The Gtk port doesn't currently draw text shadows for text decorations such as underlines.
Comment 1 Jonathon Jongsma (jonner) 2008-06-19 13:36:48 PDT 
Created attachment 21849 [details]
patch to implement drawing shadows for lines
Comment 2 Jonathon Jongsma (jonner) 2008-06-24 12:59:25 PDT 
Created attachment 21914 [details]
Updated patch due to changes from bug #19727
Comment 3 Eric Seidel (no email) 2008-08-01 16:54:25 PDT 
Comment on attachment 21914 [details]
Updated patch due to changes from bug #19727

Isn't "drawLineForText" used for drawing underlines?

Also this seems like kinda a gross hack.  But maybe this is the cleanest way to do this with Cairo.

Also, you don't respect Shadow-blur.  I think that we should come up with a better way of drawing Cairo shadows instead of this.

A shadow is a second copy of the entire image drawn at an offset and blurred.
Comment 4 Martin Robinson 2010-11-27 08:21:53 PST 

*** This bug has been marked as a duplicate of bug 48074 ***