Bug 196750 – Add runJavaScriptInFrame for WebPageProxy/WebPage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Add runJavaScriptInFrame for WebPageProxy/WebPage.

[Radar WebKit Bug Importer]

<rdar://problem/49755738>

[Jiewen Tan]

Created attachment 367082 [details]
Patch

[youenn fablet]

Comment on attachment 367082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367082&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:3570
>      m_process->send(Messages::WebPage::RunJavaScriptInMainFrameScriptWorld(script, forceUserGesture, worldName, callbackID), m_pageID);

It seems there is not much difference of processing in WebProcess between the different runJavaScript messages.
We could call runJavaScriptInFrame here and have just one IPC message for all cases.

[Jiewen Tan]

Comment on attachment 367082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367082&action=review

>> Source/WebKit/UIProcess/WebPageProxy.cpp:3570
>>      m_process->send(Messages::WebPage::RunJavaScriptInMainFrameScriptWorld(script, forceUserGesture, worldName, callbackID), m_pageID);
> 
> It seems there is not much difference of processing in WebProcess between the different runJavaScript messages.
> We could call runJavaScriptInFrame here and have just one IPC message for all cases.

Sounds like a good idea. In fact, I hesitated a bit on that approach in development. The reason for that is whether or not to give main frames a more streamline implementation than subframes. For main frames, we don't need to ask the hash table to get back a WebFrame/WebFrameProxy. WebPage/WebPageProxy stores them directly.

[Jiewen Tan]

Thanks Youenn for r+ the patch.

[Jiewen Tan]

Comment on attachment 367082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367082&action=review

>>> Source/WebKit/UIProcess/WebPageProxy.cpp:3570
>>>      m_process->send(Messages::WebPage::RunJavaScriptInMainFrameScriptWorld(script, forceUserGesture, worldName, callbackID), m_pageID);
>> 
>> It seems there is not much difference of processing in WebProcess between the different runJavaScript messages.
>> We could call runJavaScriptInFrame here and have just one IPC message for all cases.
> 
> Sounds like a good idea. In fact, I hesitated a bit on that approach in development. The reason for that is whether or not to give main frames a more streamline implementation than subframes. For main frames, we don't need to ask the hash table to get back a WebFrame/WebFrameProxy. WebPage/WebPageProxy stores them directly.

It turns out that m_mainFrame could be null in the WebPageProxy when runJavaScriptInMainFrame get called, and therefore there is no way to get the frameID in WebPageProxy and pass it to WebPage. I will land the patch as it is then.

[WebKit Commit Bot]

Comment on attachment 367082 [details]
Patch

Clearing flags on attachment: 367082

Committed r244148: <https://trac.webkit.org/changeset/244148>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.