Bug 196742 - [CMake] JavaScriptCore derived sources should only be referenced inside JavaScriptCore
Summary: [CMake] JavaScriptCore derived sources should only be referenced inside JavaS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 196704
  Show dependency tree / graph
 
Reported: 2019-04-09 12:25 PDT by Don Olmstead
Modified: 2019-04-14 07:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (38.35 KB, patch)
2019-04-12 16:16 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-04-09 12:25:52 PDT 
Anything outside of Source/JavaScriptCore should NOT be touching JavaScriptCore's derived sources.
Comment 1 Don Olmstead 2019-04-12 16:16:47 PDT 
Created attachment 367355 [details]
Patch
Comment 2 Konstantin Tokarev 2019-04-13 19:26:11 PDT 
Comment on attachment 367355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367355&action=review

> ChangeLog:9
> +        to support moving the JavaScriptCore derived sources outside of a shared directory.

Does it change anything besides variable name? Seems like both JavaScriptCore_DERIVED_SOURCES_DIR and DERIVED_SOURCES_JAVASCRIPTCORE_DIR point to the same path now
Comment 3 WebKit Commit Bot 2019-04-14 06:50:06 PDT 
Comment on attachment 367355 [details]
Patch

Clearing flags on attachment: 367355

Committed r244245: <https://trac.webkit.org/changeset/244245>
Comment 4 WebKit Commit Bot 2019-04-14 06:50:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Don Olmstead 2019-04-14 07:12:55 PDT 
(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 367355 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367355&action=review
> 
> > ChangeLog:9
> > +        to support moving the JavaScriptCore derived sources outside of a shared directory.
> 
> Does it change anything besides variable name? Seems like both
> JavaScriptCore_DERIVED_SOURCES_DIR and DERIVED_SOURCES_JAVASCRIPTCORE_DIR
> point to the same path now

I'm using WinCairo as the canary in the coal mine here. It overrides the directory.