Bug 196735 - SWClientConnection should not double hop to fire some events
Summary: SWClientConnection should not double hop to fire some events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
: 190828 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-04-09 09:46 PDT by youenn fablet
Modified: 2019-04-11 14:27 PDT (History)
6 users (show)

See Also:


Attachments
Patch (18.40 KB, patch)
2019-04-09 10:00 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (25.06 KB, patch)
2019-04-10 09:13 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-04-09 09:46:42 PDT
postMessage in service workers is hopping from main thread to service worker thread to dispatch events.
Ditto for fetch event.
Some other events though are hopping from main thread to service worker thread, then posting a task to dispatch events.
This may create ordering problems
Comment 1 youenn fablet 2019-04-09 10:00:40 PDT
Created attachment 367046 [details]
Patch
Comment 2 youenn fablet 2019-04-10 09:13:47 PDT
Created attachment 367126 [details]
Patch
Comment 3 WebKit Commit Bot 2019-04-10 15:55:07 PDT
Comment on attachment 367126 [details]
Patch

Clearing flags on attachment: 367126

Committed r244160: <https://trac.webkit.org/changeset/244160>
Comment 4 WebKit Commit Bot 2019-04-10 15:55:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-10 15:56:19 PDT
<rdar://problem/49794126>
Comment 6 youenn fablet 2019-04-11 14:27:45 PDT
*** Bug 190828 has been marked as a duplicate of this bug. ***