Bug 196734 - [CMake] Cleanup CMake files after target-oriented changes
Summary: [CMake] Cleanup CMake files after target-oriented changes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-09 09:36 PDT by Don Olmstead
Modified: 2019-04-09 10:09 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-04-09 09:36:26 PDT 
While working on cleaning up things for https://bugs.webkit.org/show_bug.cgi?id=196704 I'm expecting to see some things that can be refactored or need to be fixed but can't be addressed till later in the process. This bug is meant to track those things so they don't get lost in the shuffle.
Comment 1 Don Olmstead 2019-04-09 09:45:30 PDT 
In Source/WTF/wtf/CMakeLists.txt the WTF_INCLUDE_DIRECTORIES should only propagate bmalloc includes.

Not fixing yet because this causes a bunch of unrelated changes to be needed.
Comment 2 Don Olmstead 2019-04-09 09:46:47 PDT 
In Source/WTF/wtf/CMakeLists.txt the forwarding headers directory is used for copying the unified bundles script.

This also requires changes to WebKitMacros.cmake
Comment 3 Don Olmstead 2019-04-09 10:09:05 PDT 
I have no idea why there are calls to WEBKIT_CREATE_FORWARDING_HEADERS inside of WTF in Source/WTF/wtf/PlatformMac.cmake