# STEPS TO REPRODUCE: 1. inspect any page 2. detach Web Inspector so it's its own window 3. view the main resource of the page 4. save the resource (⌘S) => the save sheet appears from the top of the window, rather than underneath the tab bar (like Safari)
<rdar://problem/49613280>
Created attachment 367016 [details] Patch
Comment on attachment 367016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367016&action=review > Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm:57 > + return NSMakeRect(0, _inspectorProxy->sheetRect().height(), _inspectorProxy->sheetRect().width(), 0); At first this appeared really weird to me, but after logging `rect` and reading the docs <https://developer.apple.com/documentation/appkit/nswindowdelegate/1419611-window?language=objc#discussion>, I think this is the right way to go. > Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm:99 > + return NSMakeRect(0, _inspectorProxy->sheetRect().height(), _inspectorProxy->sheetRect().width(), 0); Ditto (>RemoteWebInspectorProxyMac.mm:57). > Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:519 > + return NSMakeRect(0, _frontendClient->sheetRect().height(), _frontendClient->sheetRect().width(), 0); Ditto (>RemoteWebInspectorProxyMac.mm:57).
Comment on attachment 367016 [details] Patch Nice! Need to fix other platforms.
Created attachment 367172 [details] Patch
Created attachment 367174 [details] Patch
Comment on attachment 367174 [details] Patch Rejecting attachment 367174 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 367174, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=367174&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196722&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 367174 from bug 196722. Fetching: https://bugs.webkit.org/attachment.cgi?id=367174 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date W: eaee47ecbebbd665d2d163aeb4a1aee412a6f439 and refs/remotes/origin/master differ, using rebase: :040000 040000 de9a7a232aba666ff91782b902139acbeedf5cde 08dcb51af906ddb6cbbdae23acc12fe0e6be7517 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date W: eaee47ecbebbd665d2d163aeb4a1aee412a6f439 and refs/remotes/origin/master differ, using rebase: :040000 040000 de9a7a232aba666ff91782b902139acbeedf5cde 08dcb51af906ddb6cbbdae23acc12fe0e6be7517 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit dc732d83800..2b5c0854895 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 244170 = dc732d83800e22179e016484bdd23a2aab31654e r244171 = 2b5c08548956d8183b1c152486f0d297f078326d Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11835673
Created attachment 367187 [details] Patch
Comment on attachment 367187 [details] Patch Clearing flags on attachment: 367187 Committed r244180: <https://trac.webkit.org/changeset/244180>
All reviewed patches have been landed. Closing bug.