Bug 196721 - LICM incorrectly assumes it'll never insert a node which provably OSR exits
Summary: LICM incorrectly assumes it'll never insert a node which provably OSR exits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-08 19:20 PDT by Saam Barati
Modified: 2019-04-23 19:14 PDT (History)
14 users (show)

See Also:


Attachments
patch (5.51 KB, patch)
2019-04-08 19:58 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (5.51 KB, patch)
2019-04-08 19:59 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-04-08 19:20:32 PDT
We might insert code that provably exits. We should gracefully handle this in LICM instead of asserting it doesn't happen.
Comment 1 Saam Barati 2019-04-08 19:56:30 PDT
<rdar://problem/49556479>
Comment 2 Saam Barati 2019-04-08 19:58:17 PDT
Created attachment 367020 [details]
patch
Comment 3 Saam Barati 2019-04-08 19:59:18 PDT
Created attachment 367021 [details]
patch
Comment 4 WebKit Commit Bot 2019-04-23 19:14:28 PDT
Comment on attachment 367021 [details]
patch

Clearing flags on attachment: 367021

Committed r244579: <https://trac.webkit.org/changeset/244579>
Comment 5 WebKit Commit Bot 2019-04-23 19:14:30 PDT
All reviewed patches have been landed.  Closing bug.