Bug 196720 - [CMake] Apple builds should use ICU_INCLUDE_DIRS
Summary: [CMake] Apple builds should use ICU_INCLUDE_DIRS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-08 18:25 PDT by Don Olmstead
Modified: 2019-04-09 09:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.95 KB, patch)
2019-04-08 18:27 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (7.16 KB, patch)
2019-04-08 18:32 PDT, Don Olmstead 		annulen: review+
Details | Formatted Diff | Diff
Patch (7.33 KB, patch)
2019-04-09 09:08 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-04-08 18:25:11 PDT 
The Apple platform is using ${DERIVED_SOURCES_WTF_DIR} for hosting the ICU headers. Instead it should stage the headers into ${ICU_INCLUDE_DIRS} so no special handling is needed.
Comment 1 Don Olmstead 2019-04-08 18:27:48 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2019-04-08 18:32:14 PDT 
Created attachment 367007 [details]
Patch
Comment 3 Konstantin Tokarev 2019-04-09 07:35:35 PDT 
Comment on attachment 367007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367007&action=review

> ChangeLog:8
> +        Set ICU_INCLUDE_DIRS for Apple platforms.

Please add description from your Bugzilla comment, it's more informative
Comment 4 Don Olmstead 2019-04-09 09:08:24 PDT 
Created attachment 367041 [details]
Patch

Adding more descriptive changelog.
Comment 5 WebKit Commit Bot 2019-04-09 09:54:12 PDT 
The commit-queue encountered the following flaky tests while processing attachment 367041 [details]:

imported/w3c/web-platform-tests/xhr/event-upload-progress.htm bug 196736 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2019-04-09 09:54:28 PDT 
The commit-queue encountered the following flaky tests while processing attachment 367041 [details]:

media/W3C/video/events/event_progress.html bug 196637 (author: pilgrim@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-04-09 09:57:28 PDT 
Comment on attachment 367041 [details]
Patch

Clearing flags on attachment: 367041

Committed r244081: <https://trac.webkit.org/changeset/244081>
Comment 8 WebKit Commit Bot 2019-04-09 09:57:29 PDT 
All reviewed patches have been landed.  Closing bug.