WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196689
Enable DFG on MIPS
https://bugs.webkit.org/show_bug.cgi?id=196689
Summary
Enable DFG on MIPS
Guillaume Emont
Reported
2019-04-08 01:30:10 PDT
Since the bytecode change, we enabled the baseline JIT on mips in
r240432
, but DFG is still missing.
Attachments
Patch
(4.58 KB, patch)
2019-04-08 01:38 PDT
,
Guillaume Emont
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Guillaume Emont
Comment 1
2019-04-08 01:38:44 PDT
Created
attachment 366920
[details]
Patch The patch enabling DFG on MIPS. All tests are passing.
Xan Lopez
Comment 2
2019-04-08 01:53:58 PDT
Comment on
attachment 366920
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=366920&action=review
Makes sense to me, just a small nit.
> Tools/Scripts/run-jsc-stress-tests:452 > +if $architecture == "x86"
I believe 'eq' is used for string comparison.
Xan Lopez
Comment 3
2019-04-08 01:58:32 PDT
(In reply to Xan Lopez from
comment #2
)
> Makes sense to me, just a small nit. > > > Tools/Scripts/run-jsc-stress-tests:452 > > +if $architecture == "x86" > > I believe 'eq' is used for string comparison.
And nevermind this, thought it was a perl script!
WebKit Commit Bot
Comment 4
2019-04-08 05:33:03 PDT
Comment on
attachment 366920
[details]
Patch Clearing flags on attachment: 366920 Committed
r244000
: <
https://trac.webkit.org/changeset/244000
>
WebKit Commit Bot
Comment 5
2019-04-08 05:33:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-04-08 05:34:18 PDT
<
rdar://problem/49693329
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug