Bug 196689 - Enable DFG on MIPS
Summary: Enable DFG on MIPS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Other Linux
: P2 Normal
Assignee: Guillaume Emont
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-08 01:30 PDT by Guillaume Emont
Modified: 2019-04-08 05:34 PDT (History)
13 users (show)

See Also:

Attachments
Patch (4.58 KB, patch)
2019-04-08 01:38 PDT, Guillaume Emont 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2019-04-08 01:30:10 PDT 
Since the bytecode change, we enabled the baseline JIT on mips in r240432, but DFG is still missing.
Comment 1 Guillaume Emont 2019-04-08 01:38:44 PDT 
Created attachment 366920 [details]
Patch

The patch enabling DFG on MIPS. All tests are passing.
Comment 2 Xan Lopez 2019-04-08 01:53:58 PDT 
Comment on attachment 366920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366920&action=review

Makes sense to me, just a small nit.

> Tools/Scripts/run-jsc-stress-tests:452
> +if $architecture == "x86"

I believe 'eq' is used for string comparison.
Comment 3 Xan Lopez 2019-04-08 01:58:32 PDT 
(In reply to Xan Lopez from comment #2)
> Makes sense to me, just a small nit.
> 
> > Tools/Scripts/run-jsc-stress-tests:452
> > +if $architecture == "x86"
> 
> I believe 'eq' is used for string comparison.

And nevermind this, thought it was a perl script!
Comment 4 WebKit Commit Bot 2019-04-08 05:33:03 PDT 
Comment on attachment 366920 [details]
Patch

Clearing flags on attachment: 366920

Committed r244000: <https://trac.webkit.org/changeset/244000>
Comment 5 WebKit Commit Bot 2019-04-08 05:33:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-08 05:34:18 PDT 
<rdar://problem/49693329>