Bug 196676 – [ews-app] Exception while loading status-bubble when no build step has started

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Noticed following exception in logs. This seems to happen when the build has just started, and ews-app has received the build-start event, but not the first step-start event. We should handle it appropriately.

2019-04-06 11:22:44,444 - Internal Server Error: /status-bubble/366884/
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner 
    response = get_response(request)
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 68, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 88, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/decorators/clickjacking.py", line 58, in wrapped_view
    resp = view_func(*args, **kwargs)
  File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 193, in get
    bubbles, show_submit_to_ews, show_failure_to_apply = self._build_bubbles_for_patch(patch)
  File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 182, in _build_bubbles_for_patch
    bubble = self._build_bubble(patch, queue)
  File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 111, in _build_bubble
    timestamp = self.get_build_timestamp(build)
  File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 130, in get_build_timestamp
    return self._iso_time(build.step_set.last().started_at)
AttributeError: 'NoneType' object has no attribute 'started_at'

[Aakash Jain]

Created attachment 368030 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 368030 [details]
Patch

Clearing flags on attachment: 368030

Committed r244547: <https://trac.webkit.org/changeset/244547>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50135802>