Bug 196674 - [ews-build] Do not upload archive when Compile Fails
Summary: [ews-build] Do not upload archive when Compile Fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-06 04:05 PDT by Aakash Jain
Modified: 2019-04-08 09:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2019-04-06 04:22 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-06 04:05:11 PDT 
When compiling webkit fails, ews unapply the patch and compiles clean tree. However after compiling clean tree, it should not upload the archive from clean tree.

In these builds, ews uploaded the archive for clean tree and trigerred API tests which passed, these api test results would be misleading since they did not test the right archive.

https://ews-build.webkit.org/#/builders/7/builds/229
https://ews-build.webkit.org/#/builders/7/builds/246
https://ews-build.webkit.org/#/builders/7/builds/249
Comment 1 Aakash Jain 2019-04-06 04:22:23 PDT 
Created attachment 366884 [details]
Patch
Comment 2 Alexey Proskuryakov 2019-04-08 09:03:06 PDT 
Comment on attachment 366884 [details]
Patch

It makes me sad that we don't have tests for such issues.
Comment 3 WebKit Commit Bot 2019-04-08 09:32:17 PDT 
Comment on attachment 366884 [details]
Patch

Clearing flags on attachment: 366884

Committed r244021: <https://trac.webkit.org/changeset/244021>
Comment 4 WebKit Commit Bot 2019-04-08 09:32:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-08 09:33:20 PDT 
<rdar://problem/49698545>