Bug 196650 - Clear Cache Storage structures before removing all related files
Summary: Clear Cache Storage structures before removing all related files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-05 10:58 PDT by youenn fablet
Modified: 2019-04-16 15:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2019-04-05 11:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-04-05 10:58:25 PDT 
Clear Cache Storage structures before removing all related files.
Comment 1 youenn fablet 2019-04-05 11:00:29 PDT 
Created attachment 366828 [details]
Patch
Comment 2 youenn fablet 2019-04-09 10:34:47 PDT 
Ping review?
Comment 3 WebKit Commit Bot 2019-04-10 15:59:19 PDT 
Comment on attachment 366828 [details]
Patch

Clearing flags on attachment: 366828

Committed r244162: <https://trac.webkit.org/changeset/244162>
Comment 4 WebKit Commit Bot 2019-04-10 15:59:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-10 16:01:03 PDT 
<rdar://problem/49794288>
Comment 6 Alex Christensen 2019-04-16 15:27:17 PDT 
Comment on attachment 366828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366828&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:528
> +            return;

We need to call the completion handler here :(