Bug 196649 - Add UIApplication background task logging for debugging
Summary: Add UIApplication background task logging for debugging
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-05 10:26 PDT by Brady Eidson
Modified: 2019-04-05 12:26 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.99 KB, patch)
2019-04-05 10:28 PDT, Brady Eidson
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.91 MB, application/zip)
2019-04-05 12:26 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2019-04-05 10:26:50 PDT
Add UIApplication background task logging for debugging

I've found this code I wrote very useful in debugging a few problems, and know I will need it again in the future. And others might too!

So let's check it in.
Comment 1 Brady Eidson 2019-04-05 10:28:04 PDT
(In reply to Brady Eidson from comment #0)
> Add UIApplication background task logging for debugging
> 
> I've found this code I wrote very useful in debugging a few problems, and
> know I will need it again in the future. And others might too!
> 
> So let's check it in.

Actually, just want to save the patch somewhere not on my machine, will try to get it landed once I find a good place for SPI to exist.
Comment 2 Brady Eidson 2019-04-05 10:28:31 PDT
Created attachment 366825 [details]
Patch
Comment 3 EWS Watchlist 2019-04-05 10:31:02 PDT
Attachment 366825 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:307:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EWS Watchlist 2019-04-05 12:25:58 PDT
Comment on attachment 366825 [details]
Patch

Attachment 366825 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11782270

New failing tests:
js/dom/custom-constructors.html
Comment 5 EWS Watchlist 2019-04-05 12:26:11 PDT
Created attachment 366834 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit