Bug 196632 - [Web GPU] Fix Web GPU experimental feature on iOS
Summary: [Web GPU] Fix Web GPU experimental feature on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-04 15:43 PDT by Justin Fan
Modified: 2019-04-08 15:12 PDT (History)
10 users (show)

See Also:

Attachments
Patch (17.02 KB, patch)
2019-04-04 15:50 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (15.98 KB, patch)
2019-04-04 16:19 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-04-04 15:43:16 PDT 
[Web GPU] Fix Web GPU experimental feature on iOS
Comment 1 Justin Fan 2019-04-04 15:50:31 PDT 
Created attachment 366766 [details]
Patch
Comment 2 Justin Fan 2019-04-04 16:19:19 PDT 
Created attachment 366768 [details]
Patch
Comment 3 Jon Lee 2019-04-04 18:03:52 PDT 
Comment on attachment 366768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366768&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Properly make Web GPU available on iOS 11+.

Are we running anything on this version? I think it's ok to just go with the latest.
Comment 4 Justin Fan 2019-04-04 18:23:32 PDT 
(In reply to Jon Lee from comment #3)
> Comment on attachment 366768 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366768&action=review
> 
> > Source/JavaScriptCore/ChangeLog:8
> > +        Properly make Web GPU available on iOS 11+.
> 
> Are we running anything on this version? I think it's ok to just go with the
> latest.

What about other iOS browser devs that may want to ship Web GPU on older iOS? Right now, all iOS features Web GPU relies on are available on 11 and above.
Comment 5 Myles C. Maxfield 2019-04-08 14:37:51 PDT 
Comment on attachment 366768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366768&action=review

>>> Source/JavaScriptCore/ChangeLog:8
>>> +        Properly make Web GPU available on iOS 11+.
>> 
>> Are we running anything on this version? I think it's ok to just go with the latest.
> 
> What about other iOS browser devs that may want to ship Web GPU on older iOS? Right now, all iOS features Web GPU relies on are available on 11 and above.

WebGPU should work on all versions that we are mechanically capable of shipping it on.
Comment 6 WebKit Commit Bot 2019-04-08 15:11:07 PDT 
Comment on attachment 366768 [details]
Patch

Clearing flags on attachment: 366768

Committed r244050: <https://trac.webkit.org/changeset/244050>
Comment 7 WebKit Commit Bot 2019-04-08 15:11:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-04-08 15:12:19 PDT 
<rdar://problem/49713476>