Bug 196628 - [ews-app] Timestamp shown in status-bubble hover-over message is in future
Summary: [ews-app] Timestamp shown in status-bubble hover-over message is in future
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-04 14:40 PDT by Aakash Jain
Modified: 2019-04-09 09:28 PDT (History)
5 users (show)

See Also:


Attachments
Screenshot indicating the issue (46.33 KB, image/png)
2019-04-04 14:40 PDT, Aakash Jain
no flags Details
Patch (1.03 KB, patch)
2019-04-08 19:22 PDT, Aakash Jain
aakash_jain: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-04 14:40:52 PDT
Created attachment 366761 [details]
Screenshot indicating the issue

Timestamp shown in ews-app's status-bubble hover-over message is in future. For example in the attached screenshot, the status-bubble is for currently in-progress build. It shows a timestamp of "April 05 2019 01:28:13 GMT -0400 (EDT)". This seems to be 8 hours ahead of the actual time.
Comment 1 Aakash Jain 2019-04-04 14:41:48 PDT
This seems to be due to incorrect timezone (UTC) in ews-app's settings.py
Comment 2 Aakash Jain 2019-04-08 19:22:31 PDT
Created attachment 367013 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-04-09 09:28:20 PDT
Comment on attachment 367013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367013&action=review

> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:142
> -TIME_ZONE = 'UTC'
> +TIME_ZONE = 'America/Los_Angeles'

What is the benefit of changing time zone here, not in UI? Ideally, we would be showing the correct time to everyone, which can only be done in client side JavaScript.