Bug 196628 - [ews-app] Timestamp shown in status-bubble hover-over message is in future
Summary: [ews-app] Timestamp shown in status-bubble hover-over message is in future
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-04-04 14:40 PDT by Aakash Jain
Modified: 2020-03-17 13:48 PDT (History)
7 users (show)

See Also:

Screenshot indicating the issue (46.33 KB, image/png)
2019-04-04 14:40 PDT, Aakash Jain
no flags Details
Patch (1.03 KB, patch)
2019-04-08 19:22 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2020-03-17 11:53 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-04 14:40:52 PDT
Created attachment 366761 [details]
Screenshot indicating the issue

Timestamp shown in ews-app's status-bubble hover-over message is in future. For example in the attached screenshot, the status-bubble is for currently in-progress build. It shows a timestamp of "April 05 2019 01:28:13 GMT -0400 (EDT)". This seems to be 8 hours ahead of the actual time.
Comment 1 Aakash Jain 2019-04-04 14:41:48 PDT
This seems to be due to incorrect timezone (UTC) in ews-app's settings.py
Comment 2 Aakash Jain 2019-04-08 19:22:31 PDT
Created attachment 367013 [details]
Comment 3 Alexey Proskuryakov 2019-04-09 09:28:20 PDT
Comment on attachment 367013 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=367013&action=review

> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:142
> +TIME_ZONE = 'America/Los_Angeles'

What is the benefit of changing time zone here, not in UI? Ideally, we would be showing the correct time to everyone, which can only be done in client side JavaScript.
Comment 4 Aakash Jain 2020-03-17 11:53:30 PDT
Created attachment 393771 [details]
Comment 5 Aakash Jain 2020-03-17 11:55:41 PDT
I finally got to the bottom of this issue. We are sending incorrect timestamp from buildbot. We are converting the timestamp to local time (pst) while generating epoch timestamp. While generating status-bubble (in django app) we interpret the timestamp as UTC time, which makes the timestamp in future.

Previous patch was just a workaround. Updated patch fixes the root-cause. Tested on uat instance.
Comment 6 EWS 2020-03-17 13:47:51 PDT
Committed r258586: <https://trac.webkit.org/changeset/258586>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393771 [details].
Comment 7 Radar WebKit Bug Importer 2020-03-17 13:48:17 PDT