Bug 196607 – [ews-app] status-bubble should display position in queue

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

While a patch is waiting in queue, ews-app's status-bubble should display its position in queue.

[Aakash Jain]

Created attachment 367158 [details]
WIP

[Kocsen Chung]

Comment on attachment 367158 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=367158&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:64
> +            bubble["queue_position"] = queue_position

nit: inconsistent use of `"` and `'`. Seems like most of it is `'` so we can stick to that.

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:178
> +        previously_sent_patches = set(Patch.objects.filter(modified__gte=from_timestamp).filter(sent_to_buildbot=True).filter(obsolete=False).filter(modified__lt=patch.modified))

nit: I think it would be more readable if the filters are above one another.

```python
Patch.objects
    .filter(x)
    .filter(y)
[...]
```

[Aakash Jain]

Created attachment 367386 [details]
Proposed patch

Incorporated review comments.

[Lucas Forschler]

Comment on attachment 367386 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367386&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:194
> +        processed_patch = set([build.patch for build in recent_builds])

should this be "processed_patches" ?

[Aakash Jain]

> should this be "processed_patches" ?
Yes, changed.

[Aakash Jain]

Committed r244284: <https://trac.webkit.org/changeset/244284>

[Radar WebKit Bug Importer]

<rdar://problem/49914755>