Bug 196606 – [GStreamer][WebRTC] An audio track should be muted when capture is interrupted by the OS.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Michael Catanzaro]

An audio track should be muted when capture is interrupted by the OS, as implemented for Apple in r237837

[Philippe Normand]

*** Bug 222569 has been marked as a duplicate of this bug. ***

[Philippe Normand]

Created attachment 425724 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 425724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425724&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:56
> +    bool interrupted() const final;

isInterrupted

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:188
> +    gboolean drop;

isDropping

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:193
> +void GStreamerCapturer::setInterrupted(bool interrupted)

isInterrupted.

> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp:143
> +void MockRealtimeAudioSourceGStreamer::setInterruptedForTesting(bool interrupted)

isInterrupted

> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.h:48
> +    bool interrupted() const final { return m_interrupted; };

isInterrupted

> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.h:56
> +    bool m_interrupted { false };

m_isInterrupted

[Philippe Normand]

Comment on attachment 425724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425724&action=review

>> Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:56
>> +    bool interrupted() const final;
> 
> isInterrupted

This is part of the RealtimeMediaSource interface, I'm not going to rename it in this patch :)

[Philippe Normand]

Created attachment 425751 [details]
Patch

[EWS]

Committed r275827 (236397@main): <https://commits.webkit.org/236397@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425751 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76544696>