Bug 196602 - [ATK] Cleanup WebKitAccessibleHyperlink
Summary: [ATK] Cleanup WebKitAccessibleHyperlink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2019-04-04 08:13 PDT by Carlos Garcia Campos
Modified: 2019-04-09 02:01 PDT (History)
11 users (show)

See Also:


Attachments
Patch (27.96 KB, patch)
2019-04-04 08:19 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (27.97 KB, patch)
2019-04-08 04:45 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-04-04 08:13:00 PDT
.
Comment 1 Radar WebKit Bug Importer 2019-04-04 08:14:35 PDT
<rdar://problem/49607151>
Comment 2 Carlos Garcia Campos 2019-04-04 08:19:22 PDT
Created attachment 366714 [details]
Patch
Comment 3 Carlos Garcia Campos 2019-04-08 04:45:27 PDT
Created attachment 366926 [details]
Patch
Comment 4 Michael Catanzaro 2019-04-08 15:13:47 PDT
Comment on attachment 366926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366926&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp:-418
> -    static volatile gsize typeVolatile = 0;
> -
> -    if (g_once_init_enter(&typeVolatile)) {
> -        static const GTypeInfo tinfo = {
> -            sizeof(WebKitAccessibleHyperlinkClass),
> -            (GBaseInitFunc) 0,
> -            (GBaseFinalizeFunc) 0,
> -            (GClassInitFunc)(GCallback) webkitAccessibleHyperlinkClassInit,
> -            (GClassFinalizeFunc) 0,
> -            0, /* class data */
> -            sizeof(WebKitAccessibleHyperlink), /* instance size */
> -            0, /* nb preallocs */
> -            (GInstanceInitFunc)(GCallback) webkitAccessibleHyperlinkInit,
> -            0 /* value table */
> -        };
> -
> -        static const GInterfaceInfo actionInfo = {
> -            (GInterfaceInitFunc)(GCallback)atkActionInterfaceInit,
> -            (GInterfaceFinalizeFunc) 0, 0
> -        };
> -
> -        GType type = g_type_register_static(ATK_TYPE_HYPERLINK, "WebKitAccessibleHyperlink", &tinfo, GTypeFlags(0));
> -        g_type_add_interface_static(type, ATK_TYPE_ACTION, &actionInfo);
> -
> -        g_once_init_leave(&typeVolatile, type);
> -    }

Heh, this is *really* old school!
Comment 5 Carlos Garcia Campos 2019-04-09 02:01:42 PDT
Committed r244072: <https://trac.webkit.org/changeset/244072>