Bug 196594 - [GTK][WPE] Use a timer to request the creation of pending tiles
Summary: [GTK][WPE] Use a timer to request the creation of pending tiles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-04 01:25 PDT by Miguel Gomez
Modified: 2019-04-04 05:51 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.99 KB, patch)
2019-04-04 02:06 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Patch (4.88 KB, patch)
2019-04-04 02:45 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Patch (5.41 KB, patch)
2019-04-04 03:33 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2019-04-04 01:25:22 PDT 
During the first flush for a layer, CoordinatedGraphicsLayer::updateContentBuffers() renders the contents of the tiles required to cover the visible area. After that, it requests a new flush to render the required tiles that are not inside the visible area yet (but belong to the cover area). But this flush request is performed with a direct call to nofityFlushRequired(), and that's discarded because we are already on a layer flush, so the remaining tiles are not rendered unless a new layer flush happens because of some other component.
Comment 1 Miguel Gomez 2019-04-04 02:06:18 PDT 
Created attachment 366704 [details]
Patch
Comment 2 Miguel Gomez 2019-04-04 02:45:22 PDT 
Created attachment 366705 [details]
Patch
Comment 3 Miguel Gomez 2019-04-04 03:33:36 PDT 
Created attachment 366706 [details]
Patch
Comment 4 WebKit Commit Bot 2019-04-04 05:51:49 PDT 
Comment on attachment 366706 [details]
Patch

Clearing flags on attachment: 366706

Committed r243866: <https://trac.webkit.org/changeset/243866>
Comment 5 WebKit Commit Bot 2019-04-04 05:51:50 PDT 
All reviewed patches have been landed.  Closing bug.