Bug 196586 - [JSC] Add dump feature for RandomizingFuzzerAgent
Summary: [JSC] Add dump feature for RandomizingFuzzerAgent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-03 18:10 PDT by Yusuke Suzuki
Modified: 2019-04-03 22:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.05 KB, patch)
2019-04-03 18:12 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-04-03 18:10:10 PDT 
[JSC] Add dump feature for RandomizingFuzzerAgent
Comment 1 Yusuke Suzuki 2019-04-03 18:12:31 PDT 
Created attachment 366685 [details]
Patch
Comment 2 EWS Watchlist 2019-04-03 18:14:20 PDT 
Attachment 366685 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:3:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer, fuzzer, fuzzer, fuzzer  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2019-04-03 18:28:55 PDT 
Committed r243843: <https://trac.webkit.org/changeset/243843>
Comment 4 Radar WebKit Bug Importer 2019-04-03 18:33:36 PDT 
<rdar://problem/49585901>
Comment 5 Ryan Haddad 2019-04-03 20:22:34 PDT 
This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3414
c:\cygwin\home\buildbot\worker\win10-release\build\source\javascriptcore\runtime\randomizingfuzzeragent.cpp(43): error C2027: use of undefined type 'JSC::CodeBlock' (compiling source file C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f2e18ffc-27.cpp) [C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj]
Comment 6 Ryan Haddad 2019-04-03 20:23:30 PDT 
It also broke the CLoop build:
https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/13372
./runtime/RandomizingFuzzerAgent.cpp:43:52: error: member access into incomplete type 'JSC::CodeBlock'
./runtime/RandomizingFuzzerAgent.cpp:43:84: error: member access into incomplete type 'JSC::CodeBlock'
Comment 7 Ryan Haddad 2019-04-03 20:44:25 PDT 
Reverted r243843 for reason:

Broke CLoop and Windows builds.

Committed r243853: <https://trac.webkit.org/changeset/243853>
Comment 8 Yusuke Suzuki 2019-04-03 22:27:39 PDT 
Committed r243857: <https://trac.webkit.org/changeset/243857>