Bug 196586 – [JSC] Add dump feature for RandomizingFuzzerAgent

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Add dump feature for RandomizingFuzzerAgent

[Yusuke Suzuki]

Created attachment 366685 [details]
Patch

[EWS Watchlist]

Attachment 366685 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:3:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer, fuzzer, fuzzer, fuzzer  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Committed r243843: <https://trac.webkit.org/changeset/243843>

[Radar WebKit Bug Importer]

<rdar://problem/49585901>

[Ryan Haddad]

This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3414
c:\cygwin\home\buildbot\worker\win10-release\build\source\javascriptcore\runtime\randomizingfuzzeragent.cpp(43): error C2027: use of undefined type 'JSC::CodeBlock' (compiling source file C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f2e18ffc-27.cpp) [C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj]

[Ryan Haddad]

It also broke the CLoop build:
https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/13372
./runtime/RandomizingFuzzerAgent.cpp:43:52: error: member access into incomplete type 'JSC::CodeBlock'
./runtime/RandomizingFuzzerAgent.cpp:43:84: error: member access into incomplete type 'JSC::CodeBlock'

[Ryan Haddad]

Reverted r243843 for reason:

Broke CLoop and Windows builds.

Committed r243853: <https://trac.webkit.org/changeset/243853>

[Yusuke Suzuki]

Committed r243857: <https://trac.webkit.org/changeset/243857>