Bug 196585 - Service Worker Process does not have the right domain name
Summary: Service Worker Process does not have the right domain name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-03 18:07 PDT by youenn fablet
Modified: 2019-06-10 13:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2019-04-03 18:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.63 KB, patch)
2019-04-04 08:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-04-03 18:07:38 PDT 
Service Worker Process does not have the right domain name.
(nullOrigin) is displayed currently.
Comment 1 youenn fablet 2019-04-03 18:09:45 PDT 
<rdar://problem/46142264>
Comment 2 youenn fablet 2019-04-03 18:10:31 PDT 
Created attachment 366684 [details]
Patch
Comment 3 Chris Dumez 2019-04-03 21:05:33 PDT 
Comment on attachment 366684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366684&action=review

> Source/WebKit/ChangeLog:10
> +        Updated extraInitializationData to go from "security-origin" to "registrabble-domain".

typo: registrabble-domain
Comment 4 youenn fablet 2019-04-04 08:45:00 PDT 
Created attachment 366716 [details]
Patch for landing
Comment 5 youenn fablet 2019-04-04 10:18:17 PDT 
I'll try to add a test for it, probably we can get this information from UIProcess/testRunner or directly in an API test.
Comment 6 WebKit Commit Bot 2019-04-04 10:44:22 PDT 
Comment on attachment 366716 [details]
Patch for landing

Clearing flags on attachment: 366716

Committed r243880: <https://trac.webkit.org/changeset/243880>
Comment 7 WebKit Commit Bot 2019-04-04 10:44:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Chris Dumez 2019-04-04 10:46:13 PDT 
(In reply to youenn fablet from comment #5)
> I'll try to add a test for it, probably we can get this information from
> UIProcess/testRunner or directly in an API test.

I did something a bit similar in ProcessSwap.SuspendedPagesInActivityMonitor.