Bug 196566 - Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h
Summary: Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-03 14:49 PDT by Ryosuke Niwa
Modified: 2019-04-03 15:18 PDT (History)
3 users (show)

See Also:

Attachments
Remove Extern C around NSMenu_Private.h (1.06 KB, patch)
2019-04-03 14:49 PDT, Ryosuke Niwa 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-04-03 14:49:08 PDT 
Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h
Comment 1 Ryosuke Niwa 2019-04-03 14:49:30 PDT 
Created attachment 366647 [details]
Remove Extern C around NSMenu_Private.h
Comment 2 EWS Watchlist 2019-04-03 14:51:39 PDT 
Attachment 366647 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:30:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2019-04-03 15:16:59 PDT 
Committed r243831: <https://trac.webkit.org/changeset/243831>
Comment 4 Radar WebKit Bug Importer 2019-04-03 15:18:01 PDT 
<rdar://problem/49576483>