Bug 196562 – Changing default website policies shouldn't change default website policies in subsequent navigations

• Status: NEW
• Component: WebKit Misc.

[Wenson Hsieh]

SSIA

[Radar WebKit Bug Importer]

<rdar://problem/49573377>

[Wenson Hsieh]

Created attachment 366679 [details]
Patch

[Wenson Hsieh]

Created attachment 366694 [details]
Fix the WPE build

[Wenson Hsieh]

Created attachment 366695 [details]
Really fix the WPE build?

[Tim Horton]

Comment on attachment 366695 [details]
Really fix the WPE build?

View in context: https://bugs.webkit.org/attachment.cgi?id=366695&action=review

> Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:65
> +        WTF::String name = field.name();
> +        WTF::String value = field.value();
> +        if (auto newHeaderField = WebCore::HTTPHeaderField::create(WTFMove(name), WTFMove(value)))
> +            customHeaderFields.append(WTFMove(*newHeaderField));

Shouldn't this use HTTPHeaderField copy constructor

[Wenson Hsieh]

Comment on attachment 366695 [details]
Really fix the WPE build?

View in context: https://bugs.webkit.org/attachment.cgi?id=366695&action=review

>> Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:65
>> +            customHeaderFields.append(WTFMove(*newHeaderField));
> 
> Shouldn't this use HTTPHeaderField copy constructor

It rather should, but HTTPHeaderField doesn't currently have a copy constructor, so I'll add one and use it here.

[Wenson Hsieh]

(In reply to Tim Horton from comment #5)
> Comment on attachment 366695 [details]
> Really fix the WPE build?
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366695&action=review
> 
> > Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:65
> > +        WTF::String name = field.name();
> > +        WTF::String value = field.value();
> > +        if (auto newHeaderField = WebCore::HTTPHeaderField::create(WTFMove(name), WTFMove(value)))
> > +            customHeaderFields.append(WTFMove(*newHeaderField));
> 
> Shouldn't this use HTTPHeaderField copy constructor

👍🏻 Changed to use the default copy constructor.

[Wenson Hsieh]

Created attachment 366746 [details]
Patch for EWS

[WebKit Commit Bot]

Comment on attachment 366746 [details]
Patch for EWS

Clearing flags on attachment: 366746

Committed r243909: <https://trac.webkit.org/changeset/243909>