Bug 196562 - Changing default website policies shouldn't change default website policies in subsequent navigations
Summary: Changing default website policies shouldn't change default website policies i...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-03 14:25 PDT by Wenson Hsieh
Modified: 2019-04-04 14:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.41 KB, patch)
2019-04-03 17:45 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Fix the WPE build (5.47 KB, patch)
2019-04-03 19:38 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Really fix the WPE build? (5.48 KB, patch)
2019-04-03 19:50 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for EWS (5.22 KB, patch)
2019-04-04 13:23 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-04-03 14:25:17 PDT
SSIA
Comment 1 Radar WebKit Bug Importer 2019-04-03 14:25:50 PDT
<rdar://problem/49573377>
Comment 2 Wenson Hsieh 2019-04-03 17:45:00 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2019-04-03 19:38:44 PDT Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2019-04-03 19:50:07 PDT
Created attachment 366695 [details]
Really fix the WPE build?
Comment 5 Tim Horton 2019-04-04 12:55:26 PDT
Comment on attachment 366695 [details]
Really fix the WPE build?

View in context: https://bugs.webkit.org/attachment.cgi?id=366695&action=review

> Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:65
> +        WTF::String name = field.name();
> +        WTF::String value = field.value();
> +        if (auto newHeaderField = WebCore::HTTPHeaderField::create(WTFMove(name), WTFMove(value)))
> +            customHeaderFields.append(WTFMove(*newHeaderField));

Shouldn't this use HTTPHeaderField copy constructor
Comment 6 Wenson Hsieh 2019-04-04 13:12:35 PDT Comment hidden (obsolete)
Comment 7 Wenson Hsieh 2019-04-04 13:20:18 PDT
(In reply to Tim Horton from comment #5)
> Comment on attachment 366695 [details]
> Really fix the WPE build?
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366695&action=review
> 
> > Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:65
> > +        WTF::String name = field.name();
> > +        WTF::String value = field.value();
> > +        if (auto newHeaderField = WebCore::HTTPHeaderField::create(WTFMove(name), WTFMove(value)))
> > +            customHeaderFields.append(WTFMove(*newHeaderField));
> 
> Shouldn't this use HTTPHeaderField copy constructor

👍🏻 Changed to use the default copy constructor.
Comment 8 Wenson Hsieh 2019-04-04 13:23:49 PDT
Created attachment 366746 [details]
Patch for EWS
Comment 9 WebKit Commit Bot 2019-04-04 14:56:44 PDT
Comment on attachment 366746 [details]
Patch for EWS

Clearing flags on attachment: 366746

Committed r243909: <https://trac.webkit.org/changeset/243909>