Bug 196559 – Undeprecate WKNavigationData

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Undeprecate WKNavigationData

[Alex Christensen]

Created attachment 366641 [details]
Patch

[EWS Watchlist]

Comment on attachment 366641 [details]
Patch

Attachment 366641 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11756417

New failing tests:
js/dom/custom-constructors.html

[EWS Watchlist]

Created attachment 366664 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Alex Christensen]

Created attachment 366737 [details]
Patch

[Alex Christensen]

EWS failure looks unrelated.

[Geoffrey Garen]

Comment on attachment 366737 [details]
Patch

r=me

[Geoffrey Garen]

Is this a real issue? Seems unrelated.

Ld /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore normal x86_64
    cd /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/Source/WebCore
    export MACOSX_DEPLOYMENT_TARGET=10.13
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -arch x86_64 -dynamiclib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -L/Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks -F/Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/PrivateFrameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks -filelist /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/WebCore.LinkFileList -unexported_symbols_list Configurations/WebCore.unexp -install_name /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/WebCore -mmacosx-version-min=10.13 -dead_strip -Xlinker -object_path_lto -Xlinker /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Obj
ects-normal/x86_64/WebCore_lto.o -stdlib=libc++ -fobjc-link-runtime -Wl,-not_for_dyld_shared_cache -lsqlite3 -lobjc -lANGLE -allowable_client WebCoreTestSupport -allowable_client WebKitLegacy -force_load /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/libPAL.a -framework CFNetwork -framework CoreAudio -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework Metal -sub_library libobjc -umbrella WebKit -framework AppKit -framework AudioUnit -framework Carbon -framework CoreUI -framework DataDetectorsCore -framework IOSurface -framework VideoToolbox -framework CoreMedia -weak-lwebrtc -framework OpenGL -framework SystemConfiguration -framework Accelerate -framework AudioToolbox -framework IOKit -framework JavaScriptCore -licucore -lobjc /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/libPAL.a -lxml2 -lz -framework QuartzCore -framework Security -compatibility_version 1 -current_version 608.1.13 -Xlinker -dependency_info -Xlinker /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/WebCore_dependency_info.dat -o /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore
duplicate symbol __ZN7WebCore15RTCIceTransportnwEm in:
    /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/RTCIceTransport.o
    /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource142.o
ld: 3 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[Alex Christensen]

http://trac.webkit.org/r243951

[Radar WebKit Bug Importer]

<rdar://problem/49660430>