IDB quota is replaced by storage-generic quota.
Created attachment 366619 [details] Patch
Created attachment 366621 [details] Patch
Created attachment 366650 [details] Patch
Created attachment 366665 [details] Patch
Comment on attachment 366665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366665&action=review > Source/WebCore/ChangeLog:8 > + No change of behavior as IDB specific quota is no longer used. State what is used instead. We're not just allowing unlimited IDB storage, right? > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:-1045 > - if (m_sqliteDB->lastError() == SQLITE_FULL) > - return IDBError { QuotaExceededError, "Could not seed initial key generator value for object store because no enough space for domain"_s }; Aren't these still necessary?
(In reply to Alex Christensen from comment #5) > Comment on attachment 366665 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366665&action=review > > > Source/WebCore/ChangeLog:8 > > + No change of behavior as IDB specific quota is no longer used. > > State what is used instead. We're not just allowing unlimited IDB storage, > right? We are defining a global quota limit. Currently this includes IDB and Cache API but should include more in the future. > > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:-1045 > > - if (m_sqliteDB->lastError() == SQLITE_FULL) > > - return IDBError { QuotaExceededError, "Could not seed initial key generator value for object store because no enough space for domain"_s }; > > Aren't these still necessary? No, these checks are per database/per thread.
Need to fix windows compilation issue
Created attachment 366847 [details] Patch
Comment on attachment 366847 [details] Patch Rejecting attachment 366847 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 366847, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=366847&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196545&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 366847 from bug 196545. Fetching: https://bugs.webkit.org/attachment.cgi?id=366847 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 40 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/win/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/Modules/indexeddb/server/IDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/IDBServer.cpp Hunk #1 succeeded at 134 (offset -4 lines). Hunk #2 FAILED at 690. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/server/IDBServer.cpp.rej patching file Source/WebCore/Modules/indexeddb/server/IDBServer.h Hunk #1 FAILED at 112. Hunk #2 FAILED at 192. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/server/IDBServer.h.rej patching file Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp Hunk #1 succeeded at 230 (offset -1 lines). Hunk #2 succeeded at 873 (offset -1 lines). Hunk #3 succeeded at 890 (offset -1 lines). Hunk #4 succeeded at 898 (offset -1 lines). Hunk #5 succeeded at 914 (offset -1 lines). Hunk #6 succeeded at 998 (offset -1 lines). Hunk #7 succeeded at 1008 (offset -1 lines). Hunk #8 succeeded at 1133 (offset -1 lines). Hunk #9 succeeded at 1216 (offset -1 lines). Hunk #10 succeeded at 1364 (offset -1 lines). Hunk #11 succeeded at 1453 (offset -1 lines). Hunk #12 succeeded at 1792 (offset -3 lines). Hunk #13 succeeded at 1824 (offset -3 lines). Hunk #14 succeeded at 1857 (offset -3 lines). Hunk #15 succeeded at 2393 (offset -17 lines). patching file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp Hunk #1 FAILED at 2267. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp.rej patching file Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h Hunk #1 succeeded at 125 with fuzz 2. patching file Source/WebCore/storage/StorageQuotaManager.h patching file Source/WebKit/NetworkProcess/NetworkProcess.cpp Hunk #1 succeeded at 2118 (offset -3 lines). Hunk #2 succeeded at 2123 with fuzz 2 (offset -7 lines). Hunk #3 succeeded at 2218 (offset -7 lines). patching file Source/WebKit/NetworkProcess/NetworkProcess.h Hunk #1 succeeded at 277 (offset -1 lines). Hunk #2 succeeded at 512 (offset -1 lines). patching file Source/WebKit/NetworkProcess/NetworkProcess.messages.in patching file Source/WebKit/UIProcess/API/C/WKContext.cpp patching file Source/WebKit/UIProcess/API/C/WKContextPrivate.h patching file Source/WebKit/UIProcess/WebProcessPool.cpp Hunk #1 succeeded at 1763 (offset -6 lines). patching file Source/WebKit/UIProcess/WebProcessPool.h Hunk #1 succeeded at 300 (offset -2 lines). patching file Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp patching file Source/WebKitLegacy/Storage/WebDatabaseProvider.h patching file Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm patching file Source/WebKitLegacy/mac/Storage/WebDatabaseManagerPrivate.h patching file Source/WebKitLegacy/win/Interfaces/IWebDatabaseManager.idl patching file Source/WebKitLegacy/win/WebDatabaseManager.cpp patching file Source/WebKitLegacy/win/WebDatabaseManager.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/TestRunner.cpp patching file Tools/DumpRenderTree/TestRunner.h patching file Tools/DumpRenderTree/mac/DumpRenderTree.mm Hunk #1 succeeded at 2027 (offset 1 line). patching file Tools/DumpRenderTree/mac/TestRunnerMac.mm patching file Tools/DumpRenderTree/win/TestRunnerWin.cpp patching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h patching file Tools/WebKitTestRunner/TestController.cpp Hunk #1 succeeded at 915 (offset 8 lines). Hunk #2 succeeded at 2999 (offset 8 lines). patching file Tools/WebKitTestRunner/TestController.h patching file Tools/WebKitTestRunner/TestInvocation.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11821236
This patch has not been landed yet, has it?
(In reply to Alexey Proskuryakov from comment #10) > This patch has not been landed yet, has it? Nope. This patch is just removing some no longer needed code since we are checking quota in a different way now.
Created attachment 375711 [details] Patch for landing
Comment on attachment 375711 [details] Patch for landing Rejecting attachment 375711 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 375711, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: atching file Tools/DumpRenderTree/mac/DumpRenderTree.mm patching file Tools/DumpRenderTree/mac/TestRunnerMac.mm patching file Tools/DumpRenderTree/win/TestRunnerWin.cpp patching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h patching file Tools/WebKitTestRunner/TestController.cpp patching file Tools/WebKitTestRunner/TestController.h patching file Tools/WebKitTestRunner/TestInvocation.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 39 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/ChangeLog patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/win/ChangeLog patching file Source/WebCore/Modules/indexeddb/server/IDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/IDBServer.cpp Hunk #1 FAILED at 135. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/server/IDBServer.cpp.rej patching file Source/WebCore/Modules/indexeddb/server/IDBServer.h patching file Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp Hunk #1 FAILED at 228. Hunk #2 succeeded at 872 (offset 1 line). Hunk #3 succeeded at 889 (offset 1 line). Hunk #4 succeeded at 897 (offset 1 line). Hunk #5 succeeded at 913 (offset 1 line). Hunk #6 succeeded at 996 (offset 1 line). Hunk #7 succeeded at 1006 (offset 1 line). Hunk #8 succeeded at 1129 (offset 1 line). Hunk #9 succeeded at 1210 (offset 1 line). Hunk #10 succeeded at 1358 (offset 1 line). Hunk #11 succeeded at 1443 (offset 1 line). Hunk #12 succeeded at 1780 (offset 1 line). Hunk #13 succeeded at 1812 (offset 1 line). Hunk #14 succeeded at 1845 (offset 1 line). 1 out of 15 hunks FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp.rej patching file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h Hunk #1 FAILED at 48. Hunk #3 succeeded at 108 (offset 3 lines). Hunk #4 succeeded at 207 (offset 4 lines). 1 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h.rej patching file Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp patching file Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h patching file Source/WebKit/NetworkProcess/NetworkProcess.cpp patching file Source/WebKit/NetworkProcess/NetworkProcess.h patching file Source/WebKit/NetworkProcess/NetworkProcess.messages.in patching file Source/WebKit/UIProcess/API/C/WKContext.cpp patching file Source/WebKit/UIProcess/API/C/WKContextPrivate.h patching file Source/WebKit/UIProcess/WebProcessPool.cpp patching file Source/WebKit/UIProcess/WebProcessPool.h patching file Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp patching file Source/WebKitLegacy/Storage/WebDatabaseProvider.h patching file Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm patching file Source/WebKitLegacy/mac/Storage/WebDatabaseManagerPrivate.h patching file Source/WebKitLegacy/win/Interfaces/IWebDatabaseManager.idl patching file Source/WebKitLegacy/win/WebDatabaseManager.cpp patching file Source/WebKitLegacy/win/WebDatabaseManager.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/TestRunner.cpp patching file Tools/DumpRenderTree/TestRunner.h patching file Tools/DumpRenderTree/mac/DumpRenderTree.mm patching file Tools/DumpRenderTree/mac/TestRunnerMac.mm patching file Tools/DumpRenderTree/win/TestRunnerWin.cpp patching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h patching file Tools/WebKitTestRunner/TestController.cpp patching file Tools/WebKitTestRunner/TestController.h patching file Tools/WebKitTestRunner/TestInvocation.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit f77acd0e8b0..779da35e28e master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 248376 = f77acd0e8b0ba4fea9f0663394e6bd072d12f159 r248377 = 9e6c4c992e37832d4bdd09fd83d16451e7b11b32 r248378 = 779da35e28e45f9964fff9bc7b8611644c36bda2 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/12874388
Created attachment 376052 [details] Rebasing
Comment on attachment 376052 [details] Rebasing Clearing flags on attachment: 376052 Committed r248526: <https://trac.webkit.org/changeset/248526>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54201783>
Reverted r248526 for reason: Caused two IndexedDB perf tests to fail Committed r248699: <https://trac.webkit.org/changeset/248699>
(In reply to Ryan Haddad from comment #18) > Reverted r248526 for reason: > > Caused two IndexedDB perf tests to fail > > Committed r248699: <https://trac.webkit.org/changeset/248699> Details in https://bugs.webkit.org/show_bug.cgi?id=200697
Created attachment 376569 [details] Patch
Comment on attachment 376569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376569&action=review > Source/WebCore/ChangeLog:9 > + Re-land r248526 with fix for performance tests. What was the fix?
(In reply to Alex Christensen from comment #21) > Comment on attachment 376569 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376569&action=review > > > Source/WebCore/ChangeLog:9 > > + Re-land r248526 with fix for performance tests. > > What was the fix? Removing the setIDBPerOriginQuota.
Comment on attachment 376569 [details] Patch Rejecting attachment 376569 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 376569, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=376569&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196545&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 376569 from bug 196545. Fetching: https://bugs.webkit.org/attachment.cgi?id=376569 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Youenn Fablet']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 42 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/win/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/Modules/indexeddb/server/IDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/IDBServer.cpp Hunk #1 FAILED at 135. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/indexeddb/server/IDBServer.cpp.rej patching file Source/WebCore/Modules/indexeddb/server/IDBServer.h patching file Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp patching file Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h patching file Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp Hunk #1 succeeded at 2298 (offset -1 lines). patching file Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h patching file Source/WebKit/NetworkProcess/NetworkProcess.cpp patching file Source/WebKit/NetworkProcess/NetworkProcess.h patching file Source/WebKit/NetworkProcess/NetworkProcess.messages.in patching file Source/WebKit/UIProcess/API/C/WKContext.cpp patching file Source/WebKit/UIProcess/API/C/WKContextPrivate.h patching file Source/WebKit/UIProcess/WebProcessPool.cpp patching file Source/WebKit/UIProcess/WebProcessPool.h patching file Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp patching file Source/WebKitLegacy/Storage/WebDatabaseProvider.h patching file Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm patching file Source/WebKitLegacy/mac/Storage/WebDatabaseManagerPrivate.h patching file Source/WebKitLegacy/win/Interfaces/IWebDatabaseManager.idl patching file Source/WebKitLegacy/win/WebDatabaseManager.cpp patching file Source/WebKitLegacy/win/WebDatabaseManager.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/TestRunner.cpp Hunk #1 succeeded at 894 (offset 1 line). Hunk #2 succeeded at 2207 (offset 1 line). patching file Tools/DumpRenderTree/TestRunner.h patching file Tools/DumpRenderTree/mac/DumpRenderTree.mm Hunk #1 succeeded at 2036 (offset 1 line). patching file Tools/DumpRenderTree/mac/TestRunnerMac.mm patching file Tools/DumpRenderTree/win/TestRunnerWin.cpp patching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp Hunk #1 succeeded at 375 (offset 1 line). patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h patching file Tools/WebKitTestRunner/TestController.cpp Hunk #1 succeeded at 940 (offset 1 line). Hunk #2 succeeded at 3065 (offset 1 line). patching file Tools/WebKitTestRunner/TestController.h patching file Tools/WebKitTestRunner/TestInvocation.cpp patching file PerformanceTests/ChangeLog patching file PerformanceTests/IndexedDB/large-binary-keys.html patching file PerformanceTests/IndexedDB/large-string-keys.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Youenn Fablet']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12939594
Created attachment 376693 [details] Patch for landing
Comment on attachment 376693 [details] Patch for landing Clearing flags on attachment: 376693 Committed r248856: <https://trac.webkit.org/changeset/248856>