Bug 19653 - Typing style lost when creating list from, indenting or outdenting an empty paragraph
Summary: Typing style lost when creating list from, indenting or outdenting an empty p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-06-18 06:27 PDT by David Bloom
Modified: 2008-06-19 17:23 PDT (History)
3 users (show)

See Also:


Attachments
patch (32.20 KB, patch)
2008-06-19 12:06 PDT, Justin Garcia
justin.garcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Bloom 2008-06-18 06:27:11 PDT
1. go to http://www.mozilla.org/editor/midasdemo/
2. change the font
3. type "foo", newline
4. create a numbered or bulleted list
5. type "bar"

expected: "bar" is in the same font as "foo"
actual: the font was reset to the default for "bar"
Comment 1 Mark Rowe (bdash) 2008-06-18 18:31:48 PDT
<rdar://problem/6020087>
Comment 2 Justin Garcia 2008-06-18 19:42:24 PDT
Happens in a couple of other scenarios as well, including on indent.  Only happens if the paragraph that contains the caret is empty.  I confirmed that this is not specific to the midasdemo.
Comment 3 Justin Garcia 2008-06-18 19:44:30 PDT
Also confirmed that this happens on all platforms.
Comment 4 Justin Garcia 2008-06-18 21:37:38 PDT
(In reply to comment #0)
> 1. go to http://www.mozilla.org/editor/midasdemo/
> 2. change the font
> 3. type "foo", newline
> 4. create a numbered or bulleted list
> 5. type "bar"
> 
> expected: "bar" is in the same font as "foo"
> actual: the font was reset to the default for "bar"

This doesn't work in FireFox, either, by the way.  Also clicking on buttons in the toolbar steals focus from the editable region in FireFox.
Comment 5 Justin Garcia 2008-06-18 21:39:15 PDT
> Also clicking on buttons in the toolbar steals focus from the editable region in FireFox.

That's a FF3 regression.
Comment 6 Justin Garcia 2008-06-19 02:13:08 PDT
I have a fix for this coming.
Comment 7 Justin Garcia 2008-06-19 12:06:02 PDT
Created attachment 21844 [details]
patch
Comment 8 Justin Garcia 2008-06-19 15:35:58 PDT
Comment on attachment 21844 [details]
patch

Sullivan reviewed this.
Comment 9 Justin Garcia 2008-06-19 17:23:31 PDT
http://trac.webkit.org/changeset/34681