Bug 196524 – Add a test for DOMCache on multiple browsing in case of private browsing

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Add a test for DOMCache on multiple browsing in case of private browsing

[youenn fablet]

Created attachment 366570 [details]
Patch

[youenn fablet]

<rdar://problem/48380454>

[EWS Watchlist]

Attachment 366570 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1275:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1290:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1292:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1307:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 366570 [details]
Patch

Attachment 366570 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11747740

New failing tests:
fast/history/link-inside-not-inside-any.html
fast/history/multiple-classes-visited.html
fast/history/link-inside-not.html
fast/history/link-inside-any.html

[EWS Watchlist]

Created attachment 366581 [details]
Archive of layout-test-results from ews549 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews549  Port: win-future  Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit

[youenn fablet]

Comment on attachment 366570 [details]
Patch

error is unrelated

[WebKit Commit Bot]

Comment on attachment 366570 [details]
Patch

Clearing flags on attachment: 366570

Committed r243814: <https://trac.webkit.org/changeset/243814>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.