Bug 196524 - Add a test for DOMCache on multiple browsing in case of private browsing
Summary: Add a test for DOMCache on multiple browsing in case of private browsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-02 20:02 PDT by youenn fablet
Modified: 2019-04-03 10:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2019-04-02 20:03 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews549 for win-future (13.29 MB, application/zip)
2019-04-02 23:13 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-04-02 20:02:33 PDT 
Add a test for DOMCache on multiple browsing in case of private browsing
Comment 1 youenn fablet 2019-04-02 20:03:30 PDT 
Created attachment 366570 [details]
Patch
Comment 2 youenn fablet 2019-04-02 20:03:54 PDT 
<rdar://problem/48380454>
Comment 3 EWS Watchlist 2019-04-02 20:07:08 PDT 
Attachment 366570 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1275:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1290:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1292:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1307:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EWS Watchlist 2019-04-02 23:13:39 PDT 
Comment on attachment 366570 [details]
Patch

Attachment 366570 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11747740

New failing tests:
fast/history/link-inside-not-inside-any.html
fast/history/multiple-classes-visited.html
fast/history/link-inside-not.html
fast/history/link-inside-any.html
Comment 5 EWS Watchlist 2019-04-02 23:13:42 PDT 
Created attachment 366581 [details]
Archive of layout-test-results from ews549 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews549  Port: win-future  Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit
Comment 6 youenn fablet 2019-04-03 08:26:35 PDT 
Comment on attachment 366570 [details]
Patch

error is unrelated
Comment 7 WebKit Commit Bot 2019-04-03 10:54:49 PDT 
Comment on attachment 366570 [details]
Patch

Clearing flags on attachment: 366570

Committed r243814: <https://trac.webkit.org/changeset/243814>
Comment 8 WebKit Commit Bot 2019-04-03 10:54:51 PDT 
All reviewed patches have been landed.  Closing bug.