Bug 196514 - HTML Parser: Remove conditional parsing of <noembed> content
Summary: HTML Parser: Remove conditional parsing of <noembed> content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-02 16:41 PDT by Chris Dumez
Modified: 2019-04-02 18:56 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.03 KB, patch)
2019-04-02 16:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-04-02 16:41:19 PDT 
Our HTML Parser has raw text handling for <noembed> content only if plugins are runnable. However, the HTML specification doesn't ask such behavior [1], and it doesn't match to our HTML serializer. We should always handle it as raw text.
Blink already made this change in https://chromium-review.googlesource.com/c/1477556.

[1] https://html.spec.whatwg.org/multipage/parsing.html#parsing-html-fragments:noembed
Comment 1 Chris Dumez 2019-04-02 16:45:40 PDT 
Created attachment 366551 [details]
Patch
Comment 2 Geoffrey Garen 2019-04-02 16:59:57 PDT 
Comment on attachment 366551 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-04-02 18:55:43 PDT 
Comment on attachment 366551 [details]
Patch

Clearing flags on attachment: 366551

Committed r243782: <https://trac.webkit.org/changeset/243782>
Comment 4 WebKit Commit Bot 2019-04-02 18:55:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-02 18:56:21 PDT 
<rdar://problem/49544147>