Bug 196513 - Web Inspector: Remote Inspector indicate callback should always happen on the main thread
Summary: Web Inspector: Remote Inspector indicate callback should always happen on the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-02 16:35 PDT by Joseph Pecoraro
Modified: 2019-04-04 00:27 PDT (History)
16 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.12 KB, patch)
2019-04-02 16:37 PDT, Joseph Pecoraro 		hi: review+
Details | Formatted Diff | Diff
[PATCH] For Bots (6.12 KB, patch)
2019-04-02 16:43 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-04-02 16:35:14 PDT 
Remote Inspector indicate callback should always happen on the main thread

Indicator show/hide affect the view hierarchy.

When there was a WebThread this would happen on the WebThread, but it would be better to happen on the MainThread with the WebThreadLock.
Comment 1 Joseph Pecoraro 2019-04-02 16:35:24 PDT 
<rdar://problem/49498284>
Comment 2 Joseph Pecoraro 2019-04-02 16:37:09 PDT 
Created attachment 366547 [details]
[PATCH] Proposed Fix
Comment 3 Devin Rousso 2019-04-02 16:41:49 PDT 
Comment on attachment 366547 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=366547&action=review

r=me, looks good to me (especially because I was there when he was working on it)

> Source/WebCore/ChangeLog:11
> +        When we have a WebThread, don't just run on the WebThread run

NIT: there should be a semicolon between "WebThread" and "run".
Comment 4 Joseph Pecoraro 2019-04-02 16:43:55 PDT 
Created attachment 366550 [details]
[PATCH] For Bots
Comment 5 WebKit Commit Bot 2019-04-03 05:42:44 PDT 
Comment on attachment 366550 [details]
[PATCH] For Bots

Clearing flags on attachment: 366550

Committed r243795: <https://trac.webkit.org/changeset/243795>
Comment 6 BJ Burg 2019-04-03 11:52:10 PDT 
Comment on attachment 366547 [details]
[PATCH] Proposed Fix

LGTM